Nix Zürich | 112 Members | |
| https://www.meetup.com/nix-zurich/ - ZHF Hackathon 25-26 May 2024 | 25 Servers |
| Sender | Message | Time |
|---|---|---|
| 26 Nov 2024 | ||
| I'm saying that in some cases, no better alternive exists. Breaking means breaking sometimes. I know that if the enable option had an equivalent replacement "mkRenamedOptionModule" could've been used to warn about the rename. In this case however, the external Api has changed and the courtesy of notifying an upgrading user has been fulfilled. Little can be done except delay the change associated with external api change. | 11:48:05 | |
| Usually, to upgrade a deployment or project from one half-yearly release to the next, some work needs to be put in to adjust to breaking changes | 11:49:42 | |
| Also "kill [...] with fire" seems a bit heavy handed, it could certainly be spaced out on 2 release cycles with a warning in the first one https://github.com/NixOS/nixpkgs/pull/326262 | 11:52:10 | |
| I think it's pretty standard to at least warn for a release before failing. Only in rare cases this isn't feasible, but here it is (by just ignoring the option being set). Honestly seems like a bit of an oversight, because it's rare for an option to be just removable like that. | 11:52:47 | |
In reply to @infinisil:matrix.orgI like this answer 😍 | 11:53:38 | |
| I actually disagree on this one | 11:54:23 | |
| If I sound.enable with 24.11 and it only warns me and does not fail my build Then I have a broken system without sound and my if-it-builds-it-works assumption is violated | 11:55:11 | |
| But this is just for this specific case | 11:55:20 | |
| It don’t mind if it throws an error, but it should then not be so verbose. | 11:55:36 | |
| This is probably the reasoning why it was immediately made an assertion instead of warning for one release | 11:55:53 | |
| Yeah I can also see that | 11:56:08 | |
| It's a very special case, this doesn't happen often, hard call | 11:56:25 | |
| We know it is going to break for a lot of people. Can we factor it in such a way that it breaks and points to the right place that shows ‘how do I fix my sound for 24.11’ without showing multiple pages of verbose errors? | 11:59:30 | |
| Anyways, this definitely isn't the right place to discuss it. I recommend opening an issue for this and checking the original PR for why it was done this way | 12:00:02 | |
In reply to @infinisil:matrix.orgI have looked for that pr and cannot find anything (but that could be my searching skills). | 12:00:51 | |
In reply to @elikoga:matrix.orgThis one | 12:01:06 | |
| Ok I will have a look and summarize what is said here. | 12:01:26 | |
| (link to git blame of relevant code line for convenience https://github.com/NixOS/nixpkgs/blame/master/nixos/modules/services/audio/alsa.nix#L6) | 12:04:46 | |
| * (link to git blame of relevant code line for convenience https://github.com/NixOS/nixpkgs/blame/master/nixos/modules/services/audio/alsa.nix#L6 ) | 12:05:01 | |
In reply to @elikoga:matrix.org Reading that thread makes me have ambivalent feelings:
Is that PR really the right place to talk about that? | 12:16:53 | |
| 27 Nov 2024 | ||
In reply to @koen:procolix.comMaybe a new "topic" (= thread) in the forum would a an appropriate place? I'm unsure what category there would be most fitting, though. | 11:47:31 | |
In reply to @koen:procolix.com*
Maybe a new "topic" (= thread) in the forum would a an appropriate place? I'm unsure what category there would be most fitting, though. | 11:47:56 | |
| @room as usual we posted a request for feedback. Please take a few minutes to leave your thoughts, critique, suggestions, praise, haikus…: https://github.com/nix-community/developer-workshop/issues/7 | 14:04:57 | |
In reply to @ners:nixos.dev Also, here's a shared photo album that currently just contains our group photo. Feel free to add your own if you have something cool to share from the weekend. We'll try to get in the rest that we took ASAP. :) (We'll soon have to find a new photo spot for our ever-growing group 😬) https://photos.app.goo.gl/bpUVA7kYm36K7aLW8 | 14:11:37 | |
| 29 Nov 2024 | ||
| @room as a gentle reminder, please take a moment to leave some feedback about the ZHF hackathon here: https://github.com/nix-community/developer-workshop/issues/7 | 07:37:26 | |
In reply to @ners:nixos.devreads similar to the meetup feedback survey that i answered yesterday. do you prefer comments on this issue? | 07:45:27 | |
| I did not realise Meetup had a survey. We don't usually get responses there, let me check. | 07:46:16 | |
| Historically we've always collected feedback on those Github tickets, so that's where I prefer it for now. | 07:46:43 | |
| 30 Nov 2024 | ||
| 18:14:04 | ||
| 6 Dec 2024 | ||
| 03:35:49 | ||