!oeFELgatfbdiAEkJAY:nixos.org

Nix Zürich

112 Members
https://www.meetup.com/nix-zurich/ - ZHF Hackathon 25-26 May 202425 Servers

Load older messages


SenderMessageTime
26 Nov 2024
@elikoga:matrix.orgelikoga

I'm saying that in some cases, no better alternive exists. Breaking means breaking sometimes.

I know that if the enable option had an equivalent replacement "mkRenamedOptionModule" could've been used to warn about the rename.

In this case however, the external Api has changed and the courtesy of notifying an upgrading user has been fulfilled. Little can be done except delay the change associated with external api change.

11:48:05
@elikoga:matrix.orgelikoga Usually, to upgrade a deployment or project from one half-yearly release to the next, some work needs to be put in to adjust to breaking changes 11:49:42
@elikoga:matrix.orgelikoga

Also "kill [...] with fire" seems a bit heavy handed, it could certainly be spaced out on 2 release cycles with a warning in the first one

https://github.com/NixOS/nixpkgs/pull/326262

11:52:10
@infinisil:matrix.orginfinisilI think it's pretty standard to at least warn for a release before failing. Only in rare cases this isn't feasible, but here it is (by just ignoring the option being set). Honestly seems like a bit of an oversight, because it's rare for an option to be just removable like that.11:52:47
@koen:fediversity.euKoen (SynQ) de Jonge
In reply to @infinisil:matrix.org
I think it's pretty standard to at least warn for a release before failing. Only in rare cases this isn't feasible, but here it is (by just ignoring the option being set). Honestly seems like a bit of an oversight, because it's rare for an option to be just removable like that.
I like this answer 😍
11:53:38
@elikoga:matrix.orgelikogaI actually disagree on this one11:54:23
@elikoga:matrix.orgelikoga

If I sound.enable with 24.11 and it only warns me and does not fail my build

Then I have a broken system without sound and my if-it-builds-it-works assumption is violated

11:55:11
@elikoga:matrix.orgelikoga But this is just for this specific case 11:55:20
@koen:fediversity.euKoen (SynQ) de JongeIt don’t mind if it throws an error, but it should then not be so verbose.11:55:36
@elikoga:matrix.orgelikoga This is probably the reasoning why it was immediately made an assertion instead of warning for one release 11:55:53
@infinisil:matrix.orginfinisilYeah I can also see that11:56:08
@infinisil:matrix.orginfinisilIt's a very special case, this doesn't happen often, hard call11:56:25
@koen:fediversity.euKoen (SynQ) de JongeWe know it is going to break for a lot of people. Can we factor it in such a way that it breaks and points to the right place that shows ‘how do I fix my sound for 24.11’ without showing multiple pages of verbose errors?11:59:30
@infinisil:matrix.orginfinisilAnyways, this definitely isn't the right place to discuss it. I recommend opening an issue for this and checking the original PR for why it was done this way12:00:02
@koen:fediversity.euKoen (SynQ) de Jonge
In reply to @infinisil:matrix.org
Anyways, this definitely isn't the right place to discuss it. I recommend opening an issue for this and checking the original PR for why it was done this way
I have looked for that pr and cannot find anything (but that could be my searching skills).
12:00:51
@elikoga:matrix.orgelikoga
In reply to @elikoga:matrix.org

Also "kill [...] with fire" seems a bit heavy handed, it could certainly be spaced out on 2 release cycles with a warning in the first one

https://github.com/NixOS/nixpkgs/pull/326262

This one
12:01:06
@koen:fediversity.euKoen (SynQ) de JongeOk I will have a look and summarize what is said here.12:01:26
@elikoga:matrix.orgelikoga (link to git blame of relevant code line for convenience https://github.com/NixOS/nixpkgs/blame/master/nixos/modules/services/audio/alsa.nix#L6) 12:04:46
@elikoga:matrix.orgelikoga * (link to git blame of relevant code line for convenience https://github.com/NixOS/nixpkgs/blame/master/nixos/modules/services/audio/alsa.nix#L6 ) 12:05:01
@koen:procolix.comKoen de Jonge (SynQ)
In reply to @elikoga:matrix.org
This one

Reading that thread makes me have ambivalent feelings:

  1. I want to just forget about it because there is no consensus there (other than K900 who is very clear in that the option sound.enable 'just has to be killed with fire'). That I can fix my config and just leave it with that. I.E. that I do not feel comfortable (as a newcomer) to engage in that discussion'.
  2. I still want to make other 'casual NixOS users' have a smoother experience if only for the reason that this 'stream of errors' is a preventable occurance.

Is that PR really the right place to talk about that?

12:16:53
27 Nov 2024
@das-g:matrix.orgdas-g
In reply to @koen:procolix.com

Reading that thread makes me have ambivalent feelings:

  1. I want to just forget about it because there is no consensus there (other than K900 who is very clear in that the option sound.enable 'just has to be killed with fire'). That I can fix my config and just leave it with that. I.E. that I do not feel comfortable (as a newcomer) to engage in that discussion'.
  2. I still want to make other 'casual NixOS users' have a smoother experience if only for the reason that this 'stream of errors' is a preventable occurance.

Is that PR really the right place to talk about that?

Maybe a new "topic" (= thread) in the forum would a an appropriate place? I'm unsure what category there would be most fitting, though.
11:47:31
@das-g:matrix.orgdas-g
In reply to @koen:procolix.com

Reading that thread makes me have ambivalent feelings:

  1. I want to just forget about it because there is no consensus there (other than K900 who is very clear in that the option sound.enable 'just has to be killed with fire'). That I can fix my config and just leave it with that. I.E. that I do not feel comfortable (as a newcomer) to engage in that discussion'.
  2. I still want to make other 'casual NixOS users' have a smoother experience if only for the reason that this 'stream of errors' is a preventable occurance.

Is that PR really the right place to talk about that?

*

Is that PR really the right place to talk about that?

Maybe a new "topic" (= thread) in the forum would a an appropriate place? I'm unsure what category there would be most fitting, though.

11:47:56
@ners:nixos.devners@room as usual we posted a request for feedback. Please take a few minutes to leave your thoughts, critique, suggestions, praise, haikus…: https://github.com/nix-community/developer-workshop/issues/714:04:57
@john-rodewald:nixos.devjohn-rodewald
In reply to @ners:nixos.dev
@room as usual we posted a request for feedback. Please take a few minutes to leave your thoughts, critique, suggestions, praise, haikus…: https://github.com/nix-community/developer-workshop/issues/7

Also, here's a shared photo album that currently just contains our group photo. Feel free to add your own if you have something cool to share from the weekend. We'll try to get in the rest that we took ASAP. :)

(We'll soon have to find a new photo spot for our ever-growing group 😬)

https://photos.app.goo.gl/bpUVA7kYm36K7aLW8

14:11:37
29 Nov 2024
@ners:nixos.devners@room as a gentle reminder, please take a moment to leave some feedback about the ZHF hackathon here: https://github.com/nix-community/developer-workshop/issues/707:37:26
@steveej0:matrix.orgsteveej
In reply to @ners:nixos.dev
@room as a gentle reminder, please take a moment to leave some feedback about the ZHF hackathon here: https://github.com/nix-community/developer-workshop/issues/7
reads similar to the meetup feedback survey that i answered yesterday. do you prefer comments on this issue?
07:45:27
@ners:nixos.devnersI did not realise Meetup had a survey. We don't usually get responses there, let me check.07:46:16
@ners:nixos.devnersHistorically we've always collected feedback on those Github tickets, so that's where I prefer it for now.07:46:43
30 Nov 2024
@maralorn:maralorn.de@maralorn:maralorn.de left the room.18:14:04
6 Dec 2024
@vengmark2:matrix.orgl0b0 joined the room.03:35:49

Show newer messages


Back to Room ListRoom Version: 10