| 30 Apr 2024 |
 rhelmot | nixpkgs and/or flake.nix will simply tell configure the exact system to use | 15:43:26 |
 John Ericson | I opened https://github.com/NixOS/nixpkgs/pull/308032 | 15:48:16 |
| John Ericson | we should make the decision entirely based on what we think is correct | 15:48:26 |
| John Ericson | not based on "what works" | 15:48:30 |
| John Ericson | as I am quite sure it can be made to work either wya | 15:48:35 |
| John Ericson | rhelmot: now as to the splicing thing, does it make sense? | 15:49:02 |
| John Ericson | we shouldnt' splice in buildPackages.freebsd because then we would be mixing source tree | 15:49:22 |
| John Ericson | freebsdBranches.${x} should always be spliced with buildPackages.freebsdBranchees.${x} | 15:49:47 |
| John Ericson | and then we will need fewer explicit arguments for the callPackage calls too | 15:50:14 |
| rhelmot | yes, I broadly understand the necessity of using the splicing tools even though I don't really understand the machinery | 15:50:24 |
| John Ericson | ok col | 15:50:43 |
| John Ericson | * ok cool | 15:50:45 |
| John Ericson | yeah the machinary is nuts | 15:50:49 |
| John Ericson | I made it and I don't like it | 15:50:53 |
| John Ericson | and no one has done me the favor of replacing it with something better alas | 15:51:07 |
| John Ericson | :) | 15:51:10 |
| rhelmot | alas indeed | 15:51:23 |
 dramforever | unrelated to the above, on mips i'm getting this when building openssh
fmt_scaled.c: In function 'scan_scaled':
fmt_scaled.c:214:1: sorry, unimplemented: argument 'used' is not supported for '-fzero-call-used-regs' on this target
214 | }
| ^
i think this is just ... not completely implemented in gcc, like it's just broken depending on what the code is doing and fmt_scaled.c just happens to deal with floats and stuff maybe. i figured out if you --without-hardening you can get the configure script to not use the broken -fzero-call-used-regs... what do i do now?
| 15:58:30 |
 artemist | In reply to @rhelmot:matrix.org
Did you build with flake.nix or ./configure && make? Configure. I couldn't actually get it to finish build without some more patches but the system in config.h was just x86_64-freebsd | 15:59:21 |
| John Ericson | rhelmot: oh I found the issue | 15:59:31 |
| John Ericson | the dot in the version | 15:59:35 |
| John Ericson | is confusing some stupid code | 15:59:40 |
| dramforever | In reply to @dramforever:matrix.org
unrelated to the above, on mips i'm getting this when building openssh
fmt_scaled.c: In function 'scan_scaled':
fmt_scaled.c:214:1: sorry, unimplemented: argument 'used' is not supported for '-fzero-call-used-regs' on this target
214 | }
| ^
i think this is just ... not completely implemented in gcc, like it's just broken depending on what the code is doing and fmt_scaled.c just happens to deal with floats and stuff maybe. i figured out if you --without-hardening you can get the configure script to not use the broken -fzero-call-used-regs... what do i do now?
i think ideally i get the openssh folks to notice this because they seem to still care https://github.com/openssh/openssh-portable/commit/f9193f03db0029fc9c31fbdb5c66a2737446bd8f | 16:00:19 |
| John Ericson | rhelmot artemist : OK I rebased (force pushed!) your branch, and fixed the splicing thing that was bugging me | 16:07:47 |
| John Ericson | you should now be able to remove lots of inherit (buildFreebsd) .... | 16:07:59 |
| rhelmot | on it!! | 16:08:09 |
| John Ericson | I think we can decide on https://github.com/NixOS/nixpkgs/pull/308032 too | 16:08:25 |
| John Ericson | and I think I can extract freebsdBranches from your main PR too, further shrinking things down | 16:08:42 |
| John Ericson | (in general I like splitting up the PR more, but I am happy to do the work pulling things out) | 16:08:52 |
| John Ericson | (rather than make you both slice and dice into tiny morsals) | 16:09:05 |
