| 30 Jun 2022 |
 Alyssa Ross | a comment in pkgs/top-level/linux-packages.nix would do | 08:44:40 |
| Alyssa Ross | no | 08:44:47 |
| Alyssa Ross | the RFC process 'is followed when one intends to make "substantial" changes to the Nix ecosystem.' | 08:45:00 |
| Alyssa Ross | this isn't a substantial change. not accepting new vendor kernels is the status quo. | 08:45:11 |
 matthewcroughan - nix.how | If you get a comment in via a PR, then I think that's basically the RFC. | 08:45:39 |
 dramforever | I think the policy is that until the RFC exists and is adopted, committers just use their discretion? | 08:45:48 |
 Linux Hackerman | In reply to @matthewcroughan:defenestrate.it
So there already exists written somewhere, something that explains that we shouldn't add vendor kernels to nixpkgs? Well, this chat for instance :) | 08:46:04 |
| matthewcroughan - nix.how | So maybe this visionfive PR can be the opportunity to get the comment in | 08:46:10 |
| Linux Hackerman | it's been discussed previously as well | 08:46:13 |
| Linux Hackerman | I agree that we should have more formal documentation on the subject | 08:46:24 |
| Linux Hackerman | I disagree that we should make things worse just because there isn't formal documentation on the subject. | 08:46:41 |
| matthewcroughan - nix.how | I don't think it's too bad though. | 08:47:05 |
| matthewcroughan - nix.how | "worse" in this case is just suboptimal, since we already do it for the pi. | 08:47:14 |
| matthewcroughan - nix.how | less than perfect :D | 08:47:28 |
| matthewcroughan - nix.how | putting it in nixos-hardware would be perfect, I guess. | 08:47:52 |
| matthewcroughan - nix.how | But nixos-hardware is definitely not something that is very active. We'd need to invest in that. | 08:48:38 |
| dramforever | I guess I should clarify that the thing I worry about most is not just linux_visionfive but all the other things in the PR | 08:48:47 |
| dramforever | there's a lot of vendor specific stuff going on | 08:48:56 |
| matthewcroughan - nix.how | Is nixos-hardware itself, very maintainable? | 08:49:33 |
| matthewcroughan - nix.how | even if it's the right concept, and right place to put things, is it very good itself? I don't know if it is. | 08:49:45 |
| Alyssa Ross | it could probably use some love | 08:49:59 |
| matthewcroughan - nix.how | Those layered imports seem wrong to me, is there a better way to do it? | 08:50:14 |
| matthewcroughan - nix.how | the chain of imports = [ ../../foo ] and then ../../foo does imports = [ ./foo/foo ] and then ./foo/foo imports ../foo | 08:50:47 |
| matthewcroughan - nix.how | * the chain of imports = [ ../../foo ] and then ../../foo does imports = [ ./foo/foo ] and then ./foo/foo imports = ../foo | 08:50:58 |
| matthewcroughan - nix.how | * the chain of imports = [ ../../foo ] and then ../../foo does imports = [ ./foo/foo ] and then ./foo/foo imports = [ ../foo ] | 08:51:03 |
| matthewcroughan - nix.how | I mean, I do that in my own configs. But my own configs are not as complex as what is in nixos-hardware | 08:51:31 |
| Alyssa Ross | https://github.com/NixOS/nixpkgs/pull/179686 | 08:51:46 |
| matthewcroughan - nix.how | In reply to @qyliss:fairydust.space
https://github.com/NixOS/nixpkgs/pull/179686 Awesome that there's already an example in nixos-hardware which you've linked to. | 08:52:33 |
| Alyssa Ross | :) | 08:53:04 |
| matthewcroughan - nix.how | nixos-hardware is comparable to a "bsp" in Yocto terminology. A "board support package" if anyone has ever used or dabbled with it. | 08:53:56 |
