| 26 Dec 2023 |
 hexa | perlPackages.XMLLibXML broke on staging-next due to a libxml2 update | 14:00:21 |
| hexa | stigo: can you check if upstream has a fix? | 14:00:31 |
| 29 Dec 2023 |
 stigo | Will have a look :) | 00:19:07 |
| stigo | * Will have a look tomorrow | 00:19:41 |
| stigo | https://matrix.to/#/!ZRgXNaHrdpGqwUnGnj:nixos.org/$b8T2LNwzl7izytYfvFXZ7ca-zbyojMyf9iVdqHtbSjE?via=nixos.org&via=matrix.org&via=nixos.dev | 00:21:36 |
| stigo | * https://matrix.to/#/!ZRgXNaHrdpGqwUnGnj:nixos.org/$b8T2LNwzl7izytYfvFXZ7ca-zbyojMyf9iVdqHtbSjE?via=nixos.org&via=matrix.org&via=nixos.dev about Spreadsheet::ParseExcel and CVE-2023-7101 | 00:21:54 |
| 31 Dec 2023 |
| stigo | In reply to @hexa:lossy.network
perlPackages.XMLLibXML broke on staging-next due to a libxml2 update sorry forgot :) i'm guessing this pr by Alyssa Ross fixes it? https://github.com/NixOS/nixpkgs/pull/277555 | 12:38:04 |
|  spacesbot - keeps a log of public NixOS channels joined the room. | 18:15:12 |
| 1 Jan 2024 |
| hexa | stigo: can you review https://github.com/NixOS/nixos-channel-scripts/pull/66/files? | 16:23:45 |
 vcunat | The only reason is that I don't know perl. | 16:24:16 |
| vcunat | I'm quite confident about the changes otherwise. | 16:24:36 |
| vcunat | (and the intention of all code around seems clear to me even without knowing perl) | 16:24:56 |
| vcunat | I don't see a good way of trying the code except "on production", so... 😎 | 16:25:50 |
| hexa | 🐍rewrite when 😄 | 16:26:03 |
| stigo | will have a look in a bit 🐪 | 16:28:58 |
| stigo | on phone, but use `eq` instead of `==` for string comparisons, and maybe good to bound the regexps with `^` and `$` | 16:32:38 |
| stigo | I can do a suggest thing when I'm at computer 💻 | 16:34:16 |
| vcunat | I did the eq now. | 16:34:57 |
| vcunat | I'm not sure about the regexps, as I wrote them the simple way they're in the whole file. | 16:35:24 |
| vcunat | It feels like if we're to make them more precise, probably do it in the whole file. | 16:35:56 |
| vcunat | But as our set of channel names is pretty simple and restricted, I don't see why complicate the regexps. | 16:36:29 |
| vcunat | Oh, man, I'm allow to push a new branch but not force-push it later? | 16:37:41 |
| vcunat | * Oh man, I'm allow to push a new branch but not force-push it later? | 16:37:45 |
| vcunat | * Oh man, I'm alloweg to push a new branch but not force-push it later? | 16:37:48 |
| vcunat | * Oh man, I'm allowed to push a new branch but not force-push it later? | 16:37:52 |
| vcunat | I guess we'll aim at squash-merge button. | 16:40:03 |
| stigo | Added a suggestion | 16:44:48 |
| hexa | vcunat: I can browse the settings, and there are no branch protection rules in place https://github.com/NixOS/nixos-channel-scripts/settings/branches https://github.com/NixOS/nixos-channel-scripts/settings/rules | 16:45:34 |
| vcunat | In reply to @hexa:lossy.network
vcunat: I can browse the settings, and there are no branch protection rules in place https://github.com/NixOS/nixos-channel-scripts/settings/branches https://github.com/NixOS/nixos-channel-scripts/settings/rules Oh, my bad. I can force-push, did it now. | 16:50:09 |
| vcunat | I was confident that I did add -f but terminal log says that I didn't. | 16:50:42 |
