| 13 Dec 2023 |
 stigo | * The error message provided in the issue says that the _scan method is missing from the Audio::Scan namespace | 20:11:38 |
 @adam:robins.wtf | https://github.com/andygrundman/Audio-Scan/blob/fc617aa26899cc6591f8fe3d7b448956974d14d5/Scan.xs#L217 | 20:11:48 |
| @adam:robins.wtf | which comes from there i believe | 20:11:54 |
| stigo | Well, also according to the error message Audio::Scan is bundled with slimserver in our derivation | 20:12:44 |
| @adam:robins.wtf | https://github.com/Logitech/slimserver/blob/public/8.4/lib/Audio/Scan.pm | 20:13:23 |
| @adam:robins.wtf | so this is another set of vendored CPAN modules apparently | 20:13:56 |
| stigo | If this bundled dependency contains some compiled librares, then this is likely the problem. | 20:14:08 |
| @adam:robins.wtf | it does. | 20:14:15 |
| stigo | * If this bundled dependency contains some compiled librares, then this is maybe the problem. | 20:14:20 |
| @adam:robins.wtf | let me try just dropping lib/Audio and using their source tarball https://github.com/Logitech/slimserver-vendor/blob/public/8.3/CPAN/Audio-Scan-1.05.tar.gz | 20:15:17 |
| @adam:robins.wtf | i didn't realize they had a third place of vendored CPAN in lib :/ | 20:16:49 |
| * stigo is confused why Audio::Scan is 1.01 on CPAN and 1.05 in slimserver... | 20:17:37 |
| @adam:robins.wtf | right... ? | 20:17:59 |
| @adam:robins.wtf | and 0.99 in that lib dir | 20:18:04 |
| @adam:robins.wtf | ok, so dropping lib/Audio works | 20:19:23 |
| @adam:robins.wtf | the slimserver folks seem like they could use some guidance on perl dependencies :) | 20:21:37 |
| @adam:robins.wtf | can i add packages to perl-packages that aren't on cpan? | 20:22:30 |
| stigo | In reply to @adam:robins.wtf
can i add packages to perl-packages that aren't on cpan? Hm, usually perlPackages. map to distribution names on CPAN. I know there are examples from outside CPAN, but not sure if it's a good idea in general. | 20:24:25 |
| stigo | If its something used in slimserver, why not keep it in that derivation? | 20:24:54 |
| @adam:robins.wtf | alternatively, i can overrideAttrs the src on a perlPackage, but version doesn't change | 20:24:58 |
| @adam:robins.wtf | i guess i can build a whole new perlpackage instead | 20:25:13 |
| stigo | For Audio::Scan you're thinking? | 20:25:13 |
| @adam:robins.wtf | yes | 20:25:20 |
| stigo | What are the differences? | 20:25:25 |
| stigo | Just wondering if this could be patched or not | 20:25:42 |
| stigo | Or if carrying Audio::Scan from slimserver is better than the one from CPAN | 20:26:00 |
| @adam:robins.wtf | > 1.05 2021-09-10
> - ID3: Fix v2.4 extended header handling.
> - WavPack DSD: fix song_length_ms calculation (Kimmo Taskinen).
>
> 1.04 2021-08-09
> - MP4: Allow seek with sample rates > 65535 (32 bits)
> - Fixed missing zlib reference in generated Makefile.
> - Link zlib based on OS.
>
| 20:28:23 |
| @adam:robins.wtf | they've bumped it a couple more times for the next release of slimserver too | 20:28:40 |
| stigo | Seems sensible to me to replace Audio::Scan with the slimserver version in perlPackages, of course not including any binaries. | 20:31:45 |
| @adam:robins.wtf | yeah, they have the sources in their vendor library. their expectation seems to be that for distros/users where the precompiled binaries don't work you run this script https://github.com/Logitech/slimserver-vendor/blob/public/8.3/CPAN/buildme.sh | 20:33:35 |
