Sender | Message | Time |
---|---|---|
6 Nov 2023 | ||
I've proposed to also only keep one version of perl5 in nixpkgs to make maintenance a bit easier, maybe two if/when perl7 ships. | 17:15:09 | |
i suspect that may be fine with slimserver, if we can get it using our perl packages instead of its own | 17:16:00 | |
so to try and move forward, am i correct in assuming i should be removing this directory and replacing it with buildInputs ? https://github.com/Logitech/slimserver/tree/public/8.3/CPAN | 17:17:19 | |
and if so, any tips to save me the time of manually tracking down all the associated packages? :) | 17:18:05 | |
In reply to @adam:robins.wtfI'd guess so, unless something needs to be patched for it to not use the CPAN directory. First I'd check what kind of error messages you get from just using the CPAN directory, likely there are some modules that are not compatible with 5.38 or maybe som nix specific patches that are missing. | 17:19:59 | |
it's currently failing with the error in https://github.com/NixOS/nixpkgs/issues/265488 | 17:21:00 | |
But I think we should wait for staging-next before trying, as it has over 600 commits to perlPackages :) I hope it will be merged into master very soon. | 17:21:08 | |
in that CPAN directory is an arch directory which has pre-compiled modules in it | 17:21:32 | |
(and doesn't have 5.38 obviously) | 17:22:31 | |
In reply to @adam:robins.wtfThose messages do not seems to be perl specific, but come from some tooling inside slimserver | 17:22:26 | |
right. | 17:24:11 | |
In reply to @stigo:matrix.org so to fix these failures, i've added perlPackages to buildInputs for the packages they provide in their pre-built vendoring. this causes version mismatch errors though. e.g.
| 17:37:22 | |
They still seem to load modules from the vendored CPAN directory according to the error message above | 17:40:43 | |
| 17:41:15 | |
Ok, so I’ll remove any that we’re providing and see where that takes me | 17:41:17 | |
In reply to @adam:robins.wtf Managed to get slimserver.pl not fail at compiling by providing the following buildInputs
And removed the CPAN directory in prePatch with | 17:50:31 | |
... also I set perlPackages to perl538Packages | 17:50:50 | |
In reply to @adam:robins.wtf* Managed to get
And removed the CPAN directory in prePatch with | 17:51:03 | |
(on top of your PR) | 17:51:42 | |
bbl, gotta run | 17:51:47 | |
Thanks! | 17:52:02 | |
didnt try the nixos module tho | 17:52:54 | |
Yeah I’ll run it though the tests that I’m improving | 17:55:27 | |
(the buildInputs above needs to be tidied up a bit as well) | 17:56:20 | |
and I get an error that our community has had before https://github.com/Logitech/slimserver/issues/138 | 18:14:37 | |
tldr; we can't use the latest DBIx | 18:14:51 | |
kept just the upstream vendored DBIx, fixed some more missing modules, and then hit this
| 18:27:25 | |
made some progress, just trying to iterate to find the exact set of modules we have to keep from upstream | 19:48:35 | |
7 Nov 2023 | ||
In reply to @adam:robins.wtfI'll have a closer look at your PR soon | 13:32:12 | |
11 Nov 2023 | ||
In reply to @stigo:matrix.orgHavent forgotten about this PR, just waiting for staging-next to be merged :) | 16:08:31 |