6 Nov 2023 |
adamcstephens ๐ | or do we drop releases earlier than upstream stops security patching? | 17:08:25 |
stigo (away) | A new version of Perl5 is released roughly every year or so, and in nixpkgs we keep the two currently maintained versions. | 17:09:03 |
stigo (away) | Which today are 5.36 and 5.38 | 17:11:27 |
adamcstephens ๐ | so 5.36 will be good until roughly may-july next year (depending on release date) | 17:12:09 |
stigo (away) | Yeah basically | 17:13:09 |
stigo (away) | Usually backwards compat is not a big issue in perl5, but there are of course some issues :) | 17:14:27 |
stigo (away) | I've proposed to also only keep one version of perl5 in nixpkgs to make maintenance a bit easier, maybe two if/when perl7 ships. | 17:15:09 |
adamcstephens ๐ | i suspect that may be fine with slimserver, if we can get it using our perl packages instead of its own | 17:16:00 |
adamcstephens ๐ | so to try and move forward, am i correct in assuming i should be removing this directory and replacing it with buildInputs ? https://github.com/Logitech/slimserver/tree/public/8.3/CPAN | 17:17:19 |
adamcstephens ๐ | and if so, any tips to save me the time of manually tracking down all the associated packages? :) | 17:18:05 |
stigo (away) | In reply to @adam:robins.wtf so to try and move forward, am i correct in assuming i should be removing this directory and replacing it with buildInputs ? https://github.com/Logitech/slimserver/tree/public/8.3/CPAN I'd guess so, unless something needs to be patched for it to not use the CPAN directory. First I'd check what kind of error messages you get from just using the CPAN directory, likely there are some modules that are not compatible with 5.38 or maybe som nix specific patches that are missing. | 17:19:59 |
adamcstephens ๐ | it's currently failing with the error in https://github.com/NixOS/nixpkgs/issues/265488 | 17:21:00 |
stigo (away) | But I think we should wait for staging-next before trying, as it has over 600 commits to perlPackages :) I hope it will be merged into master very soon. | 17:21:08 |
adamcstephens ๐ | in that CPAN directory is an arch directory which has pre-compiled modules in it | 17:21:32 |
adamcstephens ๐ | (and doesn't have 5.38 obviously) | 17:22:31 |
stigo (away) | In reply to @adam:robins.wtf it's currently failing with the error in https://github.com/NixOS/nixpkgs/issues/265488 Those messages do not seems to be perl specific, but come from some tooling inside slimserver | 17:22:26 |
adamcstephens ๐ | right. | 17:24:11 |
adamcstephens ๐ | In reply to @stigo:matrix.org Those messages do not seems to be perl specific, but come from some tooling inside slimserver so to fix these failures, i've added perlPackages to buildInputs for the packages they provide in their pre-built vendoring. this causes version mismatch errors though. e.g.
machine # [ 5.747365] slimserver.pl[848]: Parser.pm and Expat.pm versions don't match at /nix/store/7s6gzxci51sf9ypabsn091pgdcxcaan5-perl5.36.1-slimserver-8.3.1/CPAN/XML/Parser.pm line 20.
| 17:37:22 |
stigo (away) | They still seem to load modules from the vendored CPAN directory according to the error message above | 17:40:43 |
stigo (away) | ...slimserver-8.3.1/CPAN/XML/Parser.pm line 20
| 17:41:15 |
adamcstephens ๐ | Ok, so Iโll remove any that weโre providing and see where that takes meย | 17:41:17 |
stigo (away) | In reply to @adam:robins.wtf Ok, so Iโll remove any that weโre providing and see where that takes meย Managed to get slimserver.pl not fail at compiling by providing the following buildInputs
buildInputs = with perlPackages; [ DBI EV ClassXSAccessor DBDSQLite CarpClan FileSlurp ExporterLite XMLParser HTMLParser JSONXS DigestSHA1 YAMLLibYAML SubName CryptOpenSSLRSA IOSocketSSL
AnyEvent ClassDataInheritable ClassInspector DBIxClass DataURIEncode FileBOM FileNext
FileWhich IOString TieCacheLRUExpires ImageScale JSONXS JSONXSVersionOneAndTwo LogLog4perl PathClass ProcBackground SQLAbstract TextUnidecode
TieCacheLRU TieRegexpHash XMLSimple URIFind HTTPDaemon DataDump
];
And removed the CPAN directory in prePatch with rm -r CPAN
| 17:50:31 |
stigo (away) | ... also I set perlPackages to perl538Packages | 17:50:50 |
stigo (away) | In reply to @adam:robins.wtf Ok, so Iโll remove any that weโre providing and see where that takes meย * Managed to get slimserver.pl not fail at compiling by providing the following buildInputs
buildInputs = with perlPackages; [ DBI EV ClassXSAccessor DBDSQLite CarpClan FileSlurp ExporterLite XMLParser HTMLParser JSONXS DigestSHA1 YAMLLibYAML SubName CryptOpenSSLRSA IOSocketSSL
AnyEvent ClassDataInheritable ClassInspector DBIxClass DataURIEncode FileBOM FileNext
FileWhich IOString TieCacheLRUExpires ImageScale JSONXS JSONXSVersionOneAndTwo LogLog4perl PathClass ProcBackground SQLAbstract TextUnidecode
TieCacheLRU TieRegexpHash XMLSimple URIFind HTTPDaemon DataDump
];
And removed the CPAN directory in prePatch with rm -r CPAN
| 17:51:03 |
stigo (away) | (on top of your PR) | 17:51:42 |
stigo (away) | bbl, gotta run | 17:51:47 |
adamcstephens ๐ | Thanks! | 17:52:02 |
stigo (away) | didnt try the nixos module tho | 17:52:54 |
adamcstephens ๐ | Yeah Iโll run it though the tests that Iโm improvingย | 17:55:27 |
stigo (away) | (the buildInputs above needs to be tidied up a bit as well) | 17:56:20 |