13 Dec 2023 |
stigo | Just wondering if this could be patched or not | 20:25:42 |
stigo | Or if carrying Audio::Scan from slimserver is better than the one from CPAN | 20:26:00 |
@adam:robins.wtf | > 1.05 2021-09-10
> - ID3: Fix v2.4 extended header handling.
> - WavPack DSD: fix song_length_ms calculation (Kimmo Taskinen).
>
> 1.04 2021-08-09
> - MP4: Allow seek with sample rates > 65535 (32 bits)
> - Fixed missing zlib reference in generated Makefile.
> - Link zlib based on OS.
>
| 20:28:23 |
@adam:robins.wtf | they've bumped it a couple more times for the next release of slimserver too | 20:28:40 |
stigo | Seems sensible to me to replace Audio::Scan with the slimserver version in perlPackages, of course not including any binaries. | 20:31:45 |
@adam:robins.wtf | yeah, they have the sources in their vendor library. their expectation seems to be that for distros/users where the precompiled binaries don't work you run this script https://github.com/Logitech/slimserver-vendor/blob/public/8.3/CPAN/buildme.sh | 20:33:35 |
stigo | according to diffoscope Audio-Scan-1.01.tar.gz Audio-Scan-1.05.tar.gz the changes seem reasonable | 20:44:04 |
@adam:robins.wtf | https://github.com/NixOS/nixpkgs/pull/274070 | 21:09:53 |
15 Dec 2023 |
| Mic92 left the room. | 12:20:49 |
26 Dec 2023 |
hexa | perlPackages.XMLLibXML broke on staging-next due to a libxml2 update | 14:00:21 |
hexa | stigo: can you check if upstream has a fix? | 14:00:31 |
29 Dec 2023 |
stigo | Will have a look :) | 00:19:07 |
stigo | * Will have a look tomorrow | 00:19:41 |
stigo | https://matrix.to/#/!ZRgXNaHrdpGqwUnGnj:nixos.org/$b8T2LNwzl7izytYfvFXZ7ca-zbyojMyf9iVdqHtbSjE?via=nixos.org&via=matrix.org&via=nixos.dev | 00:21:36 |
stigo | * https://matrix.to/#/!ZRgXNaHrdpGqwUnGnj:nixos.org/$b8T2LNwzl7izytYfvFXZ7ca-zbyojMyf9iVdqHtbSjE?via=nixos.org&via=matrix.org&via=nixos.dev about Spreadsheet::ParseExcel and CVE-2023-7101 | 00:21:54 |
31 Dec 2023 |
stigo | In reply to @hexa:lossy.network perlPackages.XMLLibXML broke on staging-next due to a libxml2 update sorry forgot :) i'm guessing this pr by Alyssa Ross fixes it? https://github.com/NixOS/nixpkgs/pull/277555 | 12:38:04 |
| spacesbot - keeps a log of public NixOS channels joined the room. | 18:15:12 |
1 Jan 2024 |
hexa | stigo: can you review https://github.com/NixOS/nixos-channel-scripts/pull/66/files? | 16:23:45 |
vcunat | The only reason is that I don't know perl. | 16:24:16 |
vcunat | I'm quite confident about the changes otherwise. | 16:24:36 |
vcunat | (and the intention of all code around seems clear to me even without knowing perl) | 16:24:56 |
vcunat | I don't see a good way of trying the code except "on production", so... π | 16:25:50 |
hexa | πrewrite when π | 16:26:03 |
stigo | will have a look in a bit πͺ | 16:28:58 |
stigo | on phone, but use `eq` instead of `==` for string comparisons, and maybe good to bound the regexps with `^` and `$` | 16:32:38 |
stigo | I can do a suggest thing when I'm at computer π» | 16:34:16 |
vcunat | I did the eq now. | 16:34:57 |
vcunat | I'm not sure about the regexps, as I wrote them the simple way they're in the whole file. | 16:35:24 |
vcunat | It feels like if we're to make them more precise, probably do it in the whole file. | 16:35:56 |
vcunat | But as our set of channel names is pretty simple and restricted, I don't see why complicate the regexps. | 16:36:29 |