!sUXcTulPzyhnqOiFPL:helsinki-systems.de

NixOS Perl

38 Members
13 Servers

Load older messages


SenderMessageTime
6 Nov 2023
@stigo:matrix.orgstigo
In reply to @adam:robins.wtf
so to try and move forward, am i correct in assuming i should be removing this directory and replacing it with buildInputs ? https://github.com/Logitech/slimserver/tree/public/8.3/CPAN
I'd guess so, unless something needs to be patched for it to not use the CPAN directory. First I'd check what kind of error messages you get from just using the CPAN directory, likely there are some modules that are not compatible with 5.38 or maybe som nix specific patches that are missing.
17:19:59
@adam:robins.wtf@adam:robins.wtfit's currently failing with the error in https://github.com/NixOS/nixpkgs/issues/26548817:21:00
@stigo:matrix.orgstigoBut I think we should wait for staging-next before trying, as it has over 600 commits to perlPackages :) I hope it will be merged into master very soon.17:21:08
@adam:robins.wtf@adam:robins.wtf in that CPAN directory is an arch directory which has pre-compiled modules in it 17:21:32
@adam:robins.wtf@adam:robins.wtf(and doesn't have 5.38 obviously)17:22:31
@stigo:matrix.orgstigo
In reply to @adam:robins.wtf
it's currently failing with the error in https://github.com/NixOS/nixpkgs/issues/265488
Those messages do not seems to be perl specific, but come from some tooling inside slimserver
17:22:26
@adam:robins.wtf@adam:robins.wtfright.17:24:11
@adam:robins.wtf@adam:robins.wtf
In reply to @stigo:matrix.org
Those messages do not seems to be perl specific, but come from some tooling inside slimserver

so to fix these failures, i've added perlPackages to buildInputs for the packages they provide in their pre-built vendoring. this causes version mismatch errors though. e.g.

machine # [    5.747365] slimserver.pl[848]: Parser.pm and Expat.pm versions don't match at /nix/store/7s6gzxci51sf9ypabsn091pgdcxcaan5-perl5.36.1-slimserver-8.3.1/CPAN/XML/Parser.pm line 20.
17:37:22
@stigo:matrix.orgstigoThey still seem to load modules from the vendored CPAN directory according to the error message above17:40:43
@stigo:matrix.orgstigo
...slimserver-8.3.1/CPAN/XML/Parser.pm line 20
17:41:15
@adam:robins.wtf@adam:robins.wtf Ok, so I’ll remove any that we’re providing and see where that takes me  17:41:17
@stigo:matrix.orgstigo
In reply to @adam:robins.wtf
Ok, so I’ll remove any that we’re providing and see where that takes me 

Managed to get slimserver.pl not fail at compiling by providing the following buildInputs

  buildInputs = with perlPackages; [ DBI EV ClassXSAccessor DBDSQLite CarpClan FileSlurp ExporterLite XMLParser HTMLParser JSONXS DigestSHA1 YAMLLibYAML SubName CryptOpenSSLRSA IOSocketSSL
                                     AnyEvent ClassDataInheritable ClassInspector DBIxClass DataURIEncode FileBOM FileNext
                                     FileWhich IOString TieCacheLRUExpires ImageScale JSONXS JSONXSVersionOneAndTwo LogLog4perl PathClass ProcBackground SQLAbstract TextUnidecode
                                     TieCacheLRU TieRegexpHash XMLSimple URIFind HTTPDaemon DataDump
                                   ];

And removed the CPAN directory in prePatch with rm -r CPAN

17:50:31
@stigo:matrix.orgstigo... also I set perlPackages to perl538Packages17:50:50
@stigo:matrix.orgstigo
In reply to @adam:robins.wtf
Ok, so I’ll remove any that we’re providing and see where that takes me 
*

Managed to get slimserver.pl not fail at compiling by providing the following buildInputs

  buildInputs = with perlPackages; [ DBI EV ClassXSAccessor DBDSQLite CarpClan FileSlurp ExporterLite XMLParser HTMLParser JSONXS DigestSHA1 YAMLLibYAML SubName CryptOpenSSLRSA IOSocketSSL
                                     AnyEvent ClassDataInheritable ClassInspector DBIxClass DataURIEncode FileBOM FileNext
                                     FileWhich IOString TieCacheLRUExpires ImageScale JSONXS JSONXSVersionOneAndTwo LogLog4perl PathClass ProcBackground SQLAbstract TextUnidecode
                                     TieCacheLRU TieRegexpHash XMLSimple URIFind HTTPDaemon DataDump
                                   ];

And removed the CPAN directory in prePatch with rm -r CPAN

17:51:03
@stigo:matrix.orgstigo(on top of your PR)17:51:42
@stigo:matrix.orgstigobbl, gotta run17:51:47
@adam:robins.wtf@adam:robins.wtf Thanks! 17:52:02
@stigo:matrix.orgstigodidnt try the nixos module tho17:52:54
@adam:robins.wtf@adam:robins.wtf Yeah I’ll run it though the tests that I’m improving  17:55:27
@stigo:matrix.orgstigo(the buildInputs above needs to be tidied up a bit as well)17:56:20
@adam:robins.wtf@adam:robins.wtfand I get an error that our community has had before https://github.com/Logitech/slimserver/issues/13818:14:37
@adam:robins.wtf@adam:robins.wtftldr; we can't use the latest DBIx18:14:51
@adam:robins.wtf@adam:robins.wtf

kept just the upstream vendored DBIx, fixed some more missing modules, and then hit this

machine # [    7.429205] slimserver.pl[851]: [23-11-06 18:25:35.4817] Carp::Clan::__ANON__ (221) Warning: Carp::Clan::__ANON__(): DBI Exception: DBD::SQLite::db prepare_cached failed: no such function: ARRAY [for Statement "SELECT me.id, me.name, me.namesort, me.musicmagic_mixable, me.namesearch, me.musicbrainz_id, me.extid FROM contributors me WHERE ARRAY(0x26996f0) = ?"] at /nix/store/5k8n8yid998qjxlhmzysmrpgd6s45r1g-perl5.36.1-slimserver-8.3.1/Slim/Schema/Storage.pm line 125
18:27:25
@adam:robins.wtf@adam:robins.wtfmade some progress, just trying to iterate to find the exact set of modules we have to keep from upstream19:48:35
7 Nov 2023
@stigo:matrix.orgstigo
In reply to @adam:robins.wtf
made some progress, just trying to iterate to find the exact set of modules we have to keep from upstream
I'll have a closer look at your PR soon
13:32:12
11 Nov 2023
@stigo:matrix.orgstigo
In reply to @stigo:matrix.org
I'll have a closer look at your PR soon
Havent forgotten about this PR, just waiting for staging-next to be merged :)
16:08:31
@adam:robins.wtf@adam:robins.wtf In the meantime I changed my PR upstream to staging-next to see how it performs. Thanks :)   17:05:13
13 Nov 2023
@adam:robins.wtf@adam:robins.wtf It looks like the slimserver PR is passing against staging-next. stigo are you waiting on this merge? https://github.com/NixOS/nixpkgs/pull/263535 20:12:34
@stigo:matrix.orgstigoyep21:54:53
15 Nov 2023
@grahamc:nixos.org@grahamc:nixos.orgchanged room power levels.16:15:19

Show newer messages


Back to Room ListRoom Version: 9