| 1 Dec 2024 |
 avocadoom | I'd appreciate any feedback on this
https://github.com/NixOS/nixos-homepage/pull/1599 | 19:12:03 |
| 11 Dec 2024 |
|  Pol joined the room. | 08:24:18 |
| Pol | thilobillerbeck (avocadoom): this commit https://github.com/NixOS/nixos-homepage/commit/79d0bdfba15d68c000aa73c11beb953bb1d7bc15, what's preventing it from being published? | 08:24:59 |
| avocadoom | As explained in your PR, the CI ran through successfully https://github.com/NixOS/nixos-homepage/actions/runs/12240419589 and thus your changes are live.
What exactly makes you think it did not succeed? Which part or element did you want to change that seems to not have been affected? | 16:28:43 |
 Martin Schwaighofer | @drupol:matrix.org: that file you changed probably does not do anything. It should probably be removed, but I am not sure why it's there in the first place, so @avocadoom:avocadoom.de: who committed it, or someone else who knows should probably take a look at that.
You would need to make that change in another file.
See also: https://github.com/NixOS/nixos-homepage/pull/1602
I would appreciate if we had a label for research-publications, so I can follow relevant PRs more easily. | 16:38:18 |
| Martin Schwaighofer | Right now the file you would need to change is src/pages/research.astro afaict. (I am not at my desk right now) | 16:40:00 |
| avocadoom | In reply to @mschwaig:matrix.org
@drupol:matrix.org: that file you changed probably does not do anything. It should probably be removed, but I am not sure why it's there in the first place, so @avocadoom:avocadoom.de: who committed it, or someone else who knows should probably take a look at that.
You would need to make that change in another file.
See also: https://github.com/NixOS/nixos-homepage/pull/1602
I would appreciate if we had a label for research-publications, so I can follow relevant PRs more easily. That maybe slipped under my radar :D guess I just reviewed the LOC, nur yes, what @mschwaig:matrix.org points out is the correct location | 18:10:06 |
| avocadoom | * That maybe slipped under my radar :D guess I just reviewed the LOC, but yes, what
@mschwaig:matrix.org points out is the correct location | 18:10:18 |
|  @stick:matrix.org left the room. | 18:36:36 |
| Pol | The commit I made is fixing the DOI | 19:53:02 |
| Pol | 
Download image.png | 19:53:08 |
| Pol | I also added a link under Ludovic Courtes | 19:53:54 |
| avocadoom | In reply to @drupol:matrix.org
The commit I made is fixing the DOI Yeah I know since I reviewed it :D | 20:10:05 |
| avocadoom | In reply to @drupol:matrix.org
sent an image. That's what I asked for, perfect :) but I guess it comes down to the wrong file being edited | 20:10:34 |
