| 24 Jan 2022 |
das_j | You can use the pretty documentation by opening https://petstore.swagger.io and pasting https://raw.githubusercontent.com/NixOS/hydra/master/hydra-api.yaml into the Explore bar on top | 11:34:01 |
@grahamc:nixos.org | das_j: I'm looking at the runcommand log PR, and I think in general it looks pretty good. Obviously I'm inclined to follow up with some tests, but I'm wondering about the naming of the log files. I'm somewhat inclined to give them either a UUID stored in the DB, or use the runcommandlog record's ID. What do you think? | 14:24:57 |
@grahamc:nixos.org | I'd want to use that ID for accessing the log's contents instead of passing in a filename to the controller, and also for determining where to write it on disk | 14:25:22 |
das_j | Yeah that makes a lot more sense, my approach was just the one with the least resistance ;) | 14:25:58 |
@grahamc:nixos.org | a UUID is nice because it gives something to do the directory sharding by | 14:27:00 |
@grahamc:nixos.org | but they're not as nice to query by | 14:28:19 |
@grahamc:nixos.org | I'm not sure we need any security properties here around URL enumeration | 14:28:46 |
@grahamc:nixos.org | though if we assume postgres >=13 (released in 2020) we get UUID generation in the database for cheap migrations: gen_random_uuid | 14:32:53 |
das_j | I think it's fair to expect everyone to upgrade to 13. I'm still too lazy for the 14 upgrade : | 14:33:30 |
das_j | * I think it's fair to expect everyone to upgrade to 13. I'm still too lazy for the 14 upgrade :( | 14:33:32 |
| 25 Jan 2022 |
@grahamc:nixos.org | fwiw I've marked https://github.com/NixOS/hydra/pull/1103 as ready to Ready for Review | 15:41:43 |
@grahamc:nixos.org | I'm running in to problems with the migration system being an incrementing number, and applying draft PRs -- I wonder if there is a more robust way to do that | 15:45:04 |
cole-h | Maybe there could be a migration-list file that runs through the files enumerated inside it sequentially, and then we can give the migrations more descriptive names as well? | 16:36:35 |
cole-h | Dunno if postgres has a way to "import" statements from another file, but that might be a way to go | 16:36:53 |
@grahamc:nixos.org | yeah that could maybe work | 16:40:49 |
| 26 Jan 2022 |
| hexa joined the room. | 23:00:13 |
| 27 Jan 2022 |
Amanda (she/her) | Was hydra/nix recently changed to delegate -source downloads to remote builders as well? I've got hydra failing for my hosts now because nixbuild.net doesn't allow network access on the building, and now lots of packages are failing to pull their source. | 00:12:39 |
@grahamc:nixos.org | I'm fairly sure Hydra has always performed source fetches on remotes | 00:34:51 |