| 19 Aug 2021 |
 sterni | I suppose you just can have a #!/usr/bin/env perl script somewhere which is added to TESTS | 21:34:32 |
| sterni | and that invokes PerlCritic in the right way | 21:34:39 |
 tomberek | grahamc (he/him):
diff --git a/Makefile.am b/Makefile.am
index 3a59d6e8..33a0817f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,11 +2,8 @@ SUBDIRS = src t doc
BOOTCLEAN_SUBDIRS = $(SUBDIRS)
DIST_SUBDIRS = $(SUBDIRS)
EXTRA_DIST = hydra-module.nix
-TESTS = perlcritic
-
-.PHONY: perlcritic
-perlcritic:
- perlcritic .
+TESTS = src t
+TESTS_ENVIRONMENT = perlcritic
install-data-local: hydra-module.nix
$(INSTALL) -d $(DESTDIR)$(datadir)/nix
| 23:02:09 |
| 20 Aug 2021 |
 @grahamc:nixos.org | I ended up just, indeed, making a TESTS .pl script to avoid interrupting hairy automake goop: https://github.com/NixOS/hydra/pull/1002/files#diff-a2c2431dcaeb95008ab4c5578c34b5f37f334783f8033f3b7616cf0b4ac3e4b1 | 14:45:57 |
| 21 Aug 2021 |
| sterni changed their display name from sterni (he/him) to sterni[m]. | 22:21:30 |
| sterni changed their display name from sterni[m] to sterni. | 22:21:49 |
|  schuelermine joined the room. | 22:25:12 |
| 24 Aug 2021 |
| @grahamc:nixos.org | anyone have opinions on this PR adding a prometheus exporter? | 15:13:52 |
| @grahamc:nixos.org | oops, this one: https://github.com/NixOS/hydra/pull/1001 | 15:14:25 |
 andi- | this PR? | 15:14:28 |
| andi- | ah | 15:14:29 |
| andi- | Probably unrelated to this PR but shouldn't we have Nix options to define all these things? Having to go back to (templated) strings feels pretty counterintuitive. | 15:15:51 |
| andi- | Also they are basically not discoverable unless you read the Hydra source (and some of the docs). | 15:16:18 |
| @grahamc:nixos.org | Good question, I, uh -- maybe? | 15:17:16 |
| @grahamc:nixos.org | I should probably put this in the PR template but I'm really looking for patches that is adjacent to / changes config to include docs at a minimum, should it also include module updates? perhaps | 15:18:36 |
| andi- | I guess for now it is fine to carry on with the status quo. As soon as some (poor) soul has put in the time to create options for everything (we know of) that changes. | 15:20:36 |
| andi- | I left a few comments on the PR. I really don't like the mmap JSON thingy that you explained there. If you wouldn't have explained it I might not have bothered. | 15:24:11 |
| @grahamc:nixos.org | yeah, I explained it because I really don't like it and would like it if someone had a better idea :) | 15:25:59 |
| @grahamc:nixos.org | replied :) | 15:33:42 |
| @grahamc:nixos.org | andi-: did you have any follow-up thoughts w.r.t. the text file exporter? | 18:09:36 |
| andi- | I haven't looked again | 18:43:56 |
|  adisbladis joined the room. | 18:48:42 |
| @grahamc:nixos.org | fair enough :) | 19:07:29 |
| 25 Aug 2021 |
 ma27 | grahamc (he/him): do you have an idea what's going on with https://hydra.nixos.org/jobset/nixpkgs/glibc-2.34#tabs-errors ? :) | 10:39:44 |
| ma27 | (it only says evaluation failed with exit code 255) | 10:39:53 |
| andi- | How hard is it to add jobset ownership to hydra? It already supports that to some degree but IIRC you can't assign jobsets to users once they are created? | 14:07:10 |
| @grahamc:nixos.org | hmm.. do jobsets have owners? | 14:08:00 |
| andi- | I've seen it in the permissions checks IIRC | 14:08:56 |
| andi- | That might have been per project. | 14:09:25 |
| andi- | I was just thinking of e.g. the haskell folks should be owner of the haskell-updates jobset etc.. So that we offload some of the admin work that is occasionally requested. | 14:10:27 |
