| 16 Jun 2021 |
 @grahamc:nixos.org | RFR: https://github.com/NixOS/hydra/pull/973 maybe ajs124 / das_j would like to look-see :) | 15:35:47 |
 ajs124 | oh no, why me | 15:39:53 |
| @grahamc:nixos.org | you know what you did | 15:42:49 |
 das_j | why me? | 15:47:01 |
| das_j | Like isn't there a name that speaks more for itself? | 15:47:11 |
| ajs124 | it literally took me until now to finally find the link in the UI to this, so I didn't need to construct a url manually | 15:50:11 |
| @grahamc:nixos.org | I actually don't know where the link to this page is | 15:51:14 |
| das_j | also (I know this isn't related to your change and I'd just be annyoing everyone for requesting you to change it) why are we naming the evals list in line 231 the same as the evals scalar in 227? | 15:51:14 |
| @grahamc:nixos.org | great question, let's change that | 15:52:01 |
| ajs124 | go to a build, in the summary, there's "Part of:". don't click that link, click the "(and N others)". that's it. | 15:52:08 |
| das_j | ajs124: Can you give an example link? | 15:52:29 |
| das_j | Or is our Hydra unaffected? | 15:52:38 |
| ajs124 | we're affected, but seeing as neither of us knew how to even get there, I think we're fine | 15:54:16 |
| das_j | Got it: https://hydra.nixos.org/build/144936736/evals | 15:54:20 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/973/commits/5d95abf54026ad1901da30fde52d614d91b9800f | 15:55:12 |
| das_j | grahamc (he/him): The new name is actually more confusing :D But now that I know what the PR actually does, it does look good | 15:55:14 |
| @grahamc:nixos.org | do you have a nicer name? | 15:58:12 |
| das_j | I don't even know what it's supposed to contain :D | 15:58:26 |
| @grahamc:nixos.org | I think one of these: https://metacpan.org/pod/DBIx::Class::ResultSet | 15:58:42 |
| @grahamc:nixos.org | maybe $eval_resultset? | 16:00:20 |
| das_j | maybe. Some type of docstring would really help out (not just here but everywhere) - does Perl have something like that? | 16:01:12 |
| @grahamc:nixos.org | I'm sure it does | 16:01:23 |
| das_j | Just for myself so I can document functions as I touch them | 16:01:25 |
| @grahamc:nixos.org | time to learn more perl | 16:01:28 |
| das_j | I prefer doing literally anything else | 16:01:54 |
| @grahamc:nixos.org | https://lukasatkinson.de/2017/perl-docstrings-put-your-pod-into-heredocs/ | 16:03:27 |
| @grahamc:nixos.org | das_j: https://github.com/NixOS/hydra/pull/973/commits/09ad52ab60bc0ee3a13bcd354a525e65828d886b#diff-cb475afcb12ac8fad0be6424e5323a6ee75eed6cac086704711b900d3409edb0 | 17:16:11 |
| @grahamc:nixos.org | anyone mind throwing a final thumb / approval on this? | 17:17:11 |
| @grahamc:nixos.org | dang look at that, some cleanup, 25 lines of docs, 100 lines of tests | 17:19:24 |
| @grahamc:nixos.org | this is the good stuff | 17:19:26 |
