!zghijEASpYQWYFzriI:nixos.org

Hydra

375 Members
109 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
15 Nov 2024
@Ericson2314:matrix.orgJohn Ericson das_j: gotcha, so you are saying this is definitely a net improvement, right? 21:40:06
@Ericson2314:matrix.orgJohn Ericsonif you like it, feel free to hit the merge button21:40:42
@Ericson2314:matrix.orgJohn EricsonI can inform the rest of the SC but I would not block a decision on this21:40:58
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
das_j: gotcha, so you are saying this is definitely a net improvement, right?
Pretty much, apart from the fact that it's nix-community. Which is not something I have a personal issue with but I can imagine other people do
21:41:31
@Ericson2314:matrix.orgJohn EricsonI say better to ask for forgiveness than permission :)21:41:54
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
if you like it, feel free to hit the merge button
I will take a look this weekend I hope. If I don't, feel free to ping and annoy me again because I likely forgot ;) I'll do my best reviewing the change
21:42:10
@Ericson2314:matrix.orgJohn EricsonOK thanks!21:42:19
@Ericson2314:matrix.orgJohn Ericsonall the code is due to the lix people, who are already using this21:42:29
@janne.hess:helsinki-systems.dedas_j
In reply to @Ericson2314:matrix.org
OK thanks!
No, thank you for upstreaming all that work
21:42:41
@Ericson2314:matrix.orgJohn EricsonI just changed nix-eval-jobs (already merged) and stuff in the flake21:42:43
@Ericson2314:matrix.orgJohn Ericsonso feel free to give it a quick and dirty review21:42:56
@Ericson2314:matrix.orgJohn Ericsonsince the code is already in production....somewhere21:43:02
@Ericson2314:matrix.orgJohn Ericsonfrankly, I don't mind if you don't look at the code at all21:43:48
@Ericson2314:matrix.orgJohn EricsonI just want to not merge it myself since you brought up the nix-comunity issue, want to make sure no one reads that as me merging over your objection21:44:14

Show newer messages


Back to Room ListRoom Version: 6