!zghijEASpYQWYFzriI:nixos.org

Hydra

376 Members
109 Servers

Load older messages


SenderMessageTime
21 Jan 2024
@autiboy:matrix.org@autiboy:matrix.org left the room.23:09:25
23 Jan 2024
@Ericson2314:matrix.orgJohn Ericsonhttps://github.com/NixOS/hydra/pull/1341 is a tiny thing if anyone wants to take a look17:22:24
@Ericson2314:matrix.orgJohn Ericsonotherwise I'll just merge17:22:27
@Ericson2314:matrix.orgJohn Ericson (no code is changed, only a struct) 17:22:36
@delroth:delroth.net@delroth:delroth.net John Ericson: https://github.com/NixOS/hydra/pull/1341/files#diff-0e7b6b6b57906dff7078309c6bef4ad2b354478ad474fa7d102591652c1dd4afR155 somehow after like 15 years of doing C++ professionally I seemingly still don't understand it - how does that even work? 17:44:18
@delroth:delroth.net@delroth:delroth.netspecifically: how can a ::Machine get built from a nix::Machine there17:44:53
@Ericson2314:matrix.orgJohn Ericson delroth: The ::machine has no fields which have to be set construction time, it just needs the new super class to be construct=ed 17:45:45
@delroth:delroth.net@delroth:delroth.netsure, but there isn't a ::Machine constructor from nix::Machine here, as far as I can tell - is that implicitly defined?17:47:48
@Ericson2314:matrix.orgJohn Ericson delroth: yes that is implicitly defined 17:49:23
@Ericson2314:matrix.orgJohn Ericson merely because ::Machine has no explicit constructor, and it has the public base class 17:49:44
@Ericson2314:matrix.orgJohn EricsonI would probably get rid of the inheritence eventually because inheritance is ugly :)17:50:11
@Ericson2314:matrix.orgJohn Ericsonbut that would be more churn because field names, so I am saving that for after the Nix-side code is cleaned up and matching Hydra17:50:35
@delroth:delroth.net@delroth:delroth.net
In reply to @Ericson2314:matrix.org
delroth: yes that is implicitly defined
after some digging the answer I was looking for was https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0017r1.html from C++17 :p
18:05:50
@delroth:delroth.net@delroth:delroth.netTIL18:05:59
@delroth:delroth.net@delroth:delroth.netI think this might be the first time I actually encounter this, somehow18:06:25
@Ericson2314:matrix.orgJohn Ericson delroth: ah OK 18:07:14
@Ericson2314:matrix.orgJohn EricsonI never did C++ pre C++17 and Nix :)18:07:26
24 Jan 2024
@donotdividebyzero:matrix.orgdonotdividebyzero joined the room.11:04:27
25 Jan 2024
@delroth:delroth.net@delroth:delroth.nethttps://github.com/NixOS/hydra/pull/1344 it finally annoyed me enough to spend 5min on it08:32:16
@k900:0upti.meK900Oh no08:32:33
@k900:0upti.meK900You could just08:32:38
@k900:0upti.meK900Do that08:32:38
@k900:0upti.meK900The entire time08:32:41
@k900:0upti.meK900Not like you as in you personally08:32:52
@k900:0upti.meK900But the ability was there08:32:56
@k900:0upti.meK900I just assumed Google makes it forced08:33:09
@delroth:delroth.net@delroth:delroth.netdon't assume someone else's malice when you could instead assume it's our own incompetence08:33:36
@delroth:delroth.net@delroth:delroth.netis that a saying? maybe it should be08:33:43
@delroth:delroth.net@delroth:delroth.net John Ericson: https://hydra.nixos.org/eval/1803854 looks like the nix-2.19 update broke stuff 08:47:09
@delroth:delroth.net@delroth:delroth.neterror: access to URI 'github:NixOS/nixpkgs/e9f06adb793d1cca5384907b3b8a4071d5d7cb19' is forbidden in restricted mode08:47:20

Show newer messages


Back to Room ListRoom Version: 6