| 7 Feb 2022 |
 @grahamc:nixos.org | * ~oh dear: | 18:05:26 |
| @grahamc:nixos.org | * ~oh dear~ | 18:05:27 |
| @grahamc:nixos.org | okay I'm fairly sure nobody is actually using these events. | 18:24:33 |
| @grahamc:nixos.org | because if somebody had they'd probably have filed a bug report about the fact that it was sending a payload with the value of:
344264.691775749.1435752\tPROJECT\tJOBSET
where those \ts are not tabs, but the string literal of a \ followed by the string literal of a t.
| 18:26:00 |
 das_j | In reply to @grahamc:nixos.org
because if somebody had they'd probably have filed a bug report about the fact that it was sending a payload with the value of:
344264.691775749.1435752\tPROJECT\tJOBSET
where those \ts are not tabs, but the string literal of a \ followed by the string literal of a t.
I'm not using these events but I assume I'd just live with the fact that it's \t and split on that đ | 18:27:23 |
| @grahamc:nixos.org | well | 18:27:34 |
| @grahamc:nixos.org | I have certain feelings of if you don't report obvious bugs and then I fix obvious bugs then it isn't on me, is that unfair? | 18:28:13 |
| das_j | No, it's totally fair | 18:29:06 |
| das_j | And as Hydra is unreleased software, it would be my fault to depend on its current behaviour | 18:29:27 |
| @grahamc:nixos.org | I do hope you see real effort from me to not break its behavior | 18:30:12 |
| das_j | In reply to @grahamc:nixos.org
I do hope you see real effort from me to not break its behavior Yeah I do. I haven't noticed any breakages you introduced that were not necessary to improve Hydra in the long run | 18:30:46 |
| @grahamc:nixos.org | đ | 18:31:03 |
| das_j | (also I think you broke our Hydra only 1 or 2 times in ways that were pretty trivial to fix) | 18:31:28 |
| @grahamc:nixos.org | Bug breaks or intentional breaks? (Thinking about missed column changes or function signature mistakes) | 18:32:11 |
| das_j | In reply to @grahamc:nixos.org
Bug breaks or intentional breaks? (Thinking about missed column changes or function signature mistakes) Intentional breaks. Yeah there was also the function signature mistake but that was easily reverted locally for the time being | 18:32:40 |
| @grahamc:nixos.org | Gotcha | 18:32:50 |
| das_j | I do however think it would be useful to document intentional breakages somewhere (unless it introduces too much work for the developer) | 18:33:26 |
| das_j | something like a changelog but without releases. Just 2021-02-07 fefefe emitted eval_* events are now tab-separated instead of \t separated | 18:34:08 |
| das_j | * something like a changelog but without releases. Just 2021-02-07 fefefe Emitted eval_* events are now tab-separated instead of \t separated | 18:34:32 |
| @grahamc:nixos.org | That does sound good. Especially, for example, the Postgres version change | 18:35:17 |
| @grahamc:nixos.org | Letâs do that and add it to the pr template | 18:35:37 |
| das_j | Yeah, I could then use either the date or the commit hash when updating my Hydra after a long time and see what I can expect to be broken | 18:35:43 |
| @grahamc:nixos.org | Yeah, seems great. | 18:37:02 |
| @grahamc:nixos.org | When I broke your hydra on purpose did you adapt or partially revert, or? | 18:37:25 |
| das_j | well adapt. there's no point in carrying patches for years and having to rebase them over time | 18:43:24 |
| das_j | also your changes did usually improve things so staying with the old working state was not ideal either | 18:43:42 |
| @grahamc:nixos.org | I just wanted to make sure it wasnât a nuisance you were actively choosing to avoid. That wouldnât be very nice! | 18:44:22 |
| das_j | nono, the only time we reverted your changes was when the signature stuff broke our hydra | 18:44:59 |
| das_j | I swear I never disliked your changes :D | 18:45:09 |
| @grahamc:nixos.org | whew, thanks :) | 18:48:08 |
