| 19 Aug 2021 |
 @grahamc:nixos.org | yeah, I don't really know how automake expects to be used to make this thing get called | 21:17:36 |
| @grahamc:nixos.org | does automake automatically call all the targets? | 21:17:44 |
 tomberek | i believe TESTS will be turned into targets that are called. https://www.gnu.org/software/automake/manual/html_node/Tests.html | 21:19:18 |
| tomberek | oh, i see what you mean | 21:21:45 |
| tomberek | PL_LOG_COMPILER | 21:24:48 |
| tomberek | you need to set the test runner to be make | 21:25:50 |
| @grahamc:nixos.org | eh? | 21:26:04 |
| @grahamc:nixos.org | what test runner? | 21:26:14 |
| tomberek | For all tests without a registered extension, the variables LOG_COMPILER, AM_LOG_FLAGS, and LOG_FLAGS may be used.
| 21:27:06 |
| tomberek | i think default behavior is for TESTS to be a list of local files, not a list of make targets | 21:28:45 |
| @grahamc:nixos.org | hrm | 21:29:58 |
| @grahamc:nixos.org | I have to assume there is a better solution here, I only added it to TESTS because it was right there | 21:31:11 |
| tomberek | i'll look after dinner | 21:34:19 |
 sterni | I suppose you just can have a #!/usr/bin/env perl script somewhere which is added to TESTS | 21:34:32 |
| sterni | and that invokes PerlCritic in the right way | 21:34:39 |
| tomberek | grahamc (he/him):
diff --git a/Makefile.am b/Makefile.am
index 3a59d6e8..33a0817f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,11 +2,8 @@ SUBDIRS = src t doc
BOOTCLEAN_SUBDIRS = $(SUBDIRS)
DIST_SUBDIRS = $(SUBDIRS)
EXTRA_DIST = hydra-module.nix
-TESTS = perlcritic
-
-.PHONY: perlcritic
-perlcritic:
- perlcritic .
+TESTS = src t
+TESTS_ENVIRONMENT = perlcritic
install-data-local: hydra-module.nix
$(INSTALL) -d $(DESTDIR)$(datadir)/nix
| 23:02:09 |
| 20 Aug 2021 |
| @grahamc:nixos.org | I ended up just, indeed, making a TESTS .pl script to avoid interrupting hairy automake goop: https://github.com/NixOS/hydra/pull/1002/files#diff-a2c2431dcaeb95008ab4c5578c34b5f37f334783f8033f3b7616cf0b4ac3e4b1 | 14:45:57 |
| 21 Aug 2021 |
| sterni changed their display name from sterni (he/him) to sterni[m]. | 22:21:30 |
| sterni changed their display name from sterni[m] to sterni. | 22:21:49 |
|  schuelermine joined the room. | 22:25:12 |
| 24 Aug 2021 |
| @grahamc:nixos.org | anyone have opinions on this PR adding a prometheus exporter? | 15:13:52 |
| @grahamc:nixos.org | oops, this one: https://github.com/NixOS/hydra/pull/1001 | 15:14:25 |
 andi- | this PR? | 15:14:28 |
| andi- | ah | 15:14:29 |
| andi- | Probably unrelated to this PR but shouldn't we have Nix options to define all these things? Having to go back to (templated) strings feels pretty counterintuitive. | 15:15:51 |
| andi- | Also they are basically not discoverable unless you read the Hydra source (and some of the docs). | 15:16:18 |
| @grahamc:nixos.org | Good question, I, uh -- maybe? | 15:17:16 |
| @grahamc:nixos.org | I should probably put this in the PR template but I'm really looking for patches that is adjacent to / changes config to include docs at a minimum, should it also include module updates? perhaps | 15:18:36 |
| andi- | I guess for now it is fine to carry on with the status quo. As soon as some (poor) soul has put in the time to create options for everything (we know of) that changes. | 15:20:36 |
| andi- | I left a few comments on the PR. I really don't like the mmap JSON thingy that you explained there. If you wouldn't have explained it I might not have bothered. | 15:24:11 |
