| 11 Jan 2022 |
@grahamc:nixos.org | :) | 01:07:28 |
@grahamc:nixos.org | I like to see PRs come with a lot of tests, which typically pushes the Perl from yucky Perl to tolerable | 01:07:59 |
@grahamc:nixos.org | imho | 01:08:01 |
@ius:nltrix.net | Are there any samples/excepts of the database anywhere? The builds/buildoutputs table in particular I guess | 01:10:06 |
@ius:nltrix.net | I wanted to give debugging it a shot (though writing anything but SQL might not be my forte) | 01:11:10 |
@grahamc:nixos.org | well ... I can try and get you an export, but it is quite large. are you on github? | 01:12:24 |
@ius:nltrix.net | Sure, same nickname. | 01:12:40 |
@grahamc:nixos.org | mind if I DM? | 01:13:07 |
@ius:nltrix.net | not at all | 01:13:15 |
@ius:nltrix.net | btw, while digging in I noticed something else | 01:14:13 |
@ius:nltrix.net | $ rg IndexBuildOutputsOnPath
upgrade-12.sql
1:create index IndexBuildOutputsOnPath on BuildOutputs(path);
| 01:14:28 |
@ius:nltrix.net | That index doesn't seem to be part of hydra.sql.. | 01:15:21 |
@ius:nltrix.net | (which I assume is the full up-to-date schema) | 01:15:35 |
@grahamc:nixos.org | yeah, it should be | 01:17:54 |
@grahamc:nixos.org | that is Interesting | 01:18:01 |
@grahamc:nixos.org | nice, I got hydra to send github statuses for builds that didn't change in a PR | 02:05:59 |
das_j | Hmm looks like the gcroot stuff doesn't work as I expected… it's currently keeping results of the last X evaluations of the jobset. Shouldn't it keep the last X evaluations per job? | 09:23:19 |
das_j | To elaborate, I have a job that doesn't evaluate anymore and the latest build (some evals ago) has been gc'ed even though it's the latest one | 09:23:50 |
@grahamc:nixos.org | that is the way I'd expect it to work | 14:29:30 |
@grahamc:nixos.org | * the way it currently works is the way I'd expect it to work | 14:29:37 |
das_j | so it does look like we have different ideas how it's supposed to work :D | 14:29:51 |
@grahamc:nixos.org | it could be very expensive to find the most recent job that builds/evaluates, especially because does it not evaluate because it was removed, or does it not evaluate because it is broken -- I don't think we differentiate | 14:31:32 |
das_j | I can try a RunCommand for that particular jobset that sets the latest job result as "Keep" (if I can figure out how I do that) | 14:32:11 |
@grahamc:nixos.org | that is an interesting idea! | 14:33:56 |
@grahamc:nixos.org | you would keep stale GC roots around for jobsets that are deleted, but that is probably f ine | 14:42:21 |
ajs124 | doesn't that happen already? | 14:42:46 |
@grahamc:nixos.org | I don't think so | 14:43:14 |
@grahamc:nixos.org | but maybe? | 14:43:16 |
das_j | I don't think so, no | 14:43:24 |
das_j | it goes over all jobsets, marks the roots to keep, and then goes over all root and deletes unmarked ones | 14:44:09 |