| 18 Oct 2021 |
 @grahamc:nixos.org | nice | 13:41:22 |
| 20 Oct 2021 |
| @grahamc:nixos.org | a small PRs reducing warning noise: https://github.com/NixOS/hydra/pull/1043
a small PR making GitHubPulls not use jq https://github.com/NixOS/hydra/pull/1042 | 02:14:02 |
 das_j | grahamc (he/him): wouldn't it be nicer to do something like return ($self->{config}->{enable_bitbucket_status} // 0) == 1;? | 06:48:41 |
| @grahamc:nixos.org | sounds nice | 13:43:17 |
| @grahamc:nixos.org | das_j: | 14:40:31 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1043/commits/a36d23c1dd6070ab8603b20e939e077b838b6ba7 | 14:40:32 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1043/commits/a887b3d3466df58b92ac3ea5cd6cc4a69ce7d095 | 14:40:38 |
| @grahamc:nixos.org | here's a PR bringing the codebase up to perlcritic level 3: https://github.com/NixOS/hydra/pull/1044 | 15:49:26 |
| das_j | what's level 3? | 15:54:59 |
| das_j | --harsh? | 15:55:12 |
| @grahamc:nixos.org | yeah | 15:57:19 |
| @grahamc:nixos.org | I like that the levels dose out reasonable amounts of errors to fix at a time, but also the lower levels expose real problems that are not just opinionated nit picking | 15:58:47 |
| @grahamc:nixos.org | so giving them names like "brutal" and "cruel" and "harsh" feels like unnecessary connotations to attach | 15:59:28 |
| das_j | but I find them funnier to mention in a conversation ;) | 15:59:47 |
| @grahamc:nixos.org | for sure :) | 15:59:51 |
 cransom | oh boy. i have a very old perl code base that i assume i'm going to have to update before it can be naturally obsolesced... i wonder if i can crash perlcritic. | 16:09:15 |
 Linux Hackerman | In reply to @grahamc:nixos.org
so giving them names like "brutal" and "cruel" and "harsh" feels like unnecessary connotations to attach Look at Graham, the perlcritic critic! :p | 16:11:53 |
| cransom | oh boy. there are ¤ characters in these package names. | 16:15:56 |
| das_j | haha iconv goes brrrr | 16:16:46 |
| cransom | cod ebase of 62,000 lines of code, 192 errors to fix at perlcritic -5. i wonder how long it would take me to bring this stuff up to perl 5.32 compatibility. | 16:21:04 |
| @grahamc:nixos.org | oh not bad | 16:21:30 |
| cransom | not sure. it's a significant amount of copy pasta. but the more difficult part. the only testing this code has ever encountered was people clicking through the site and 'does this look right? i guess' | 16:24:13 |
| @grahamc:nixos.org | ouch | 16:32:13 |
| @grahamc:nixos.org | does anyone intend on reviewing #1044 (perlcritic level 3)? I'd love some eyes on it, but if not I'm inclined to just press the button | 16:32:43 |
| das_j | I can take a look but I can't guarantee I'll spot all issues ;) | 16:35:17 |
| @grahamc:nixos.org | of course not | 16:36:42 |
 Rick (Mindavi) | I looked earlier, but it looks different now :p, don't see any obvious issues but I've never written perl | 16:37:02 |
| Rick (Mindavi) | Was wondering about the dependency that was added though | 16:37:14 |
| @grahamc:nixos.org | 👍️just replied on the thread | 16:38:26 |
| das_j | Is there a perlcritic level that complains about calls without parathesis btw? :P | 16:46:44 |
