| 7 Sep 2021 |
sterni | and virtually every function will do something half reasonable with undef so it ends up failing in a completely different place usually | 15:19:29 |
@grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1004 | 15:19:36 |
@grahamc:nixos.org | you can define prototypes | 15:21:25 |
@grahamc:nixos.org | to say what arguments it requires and vaguely what type it is expecting, but you can't do this for -> called subs | 15:22:39 |
sterni | so that's 99% of hydra | 15:30:42 |
@grahamc:nixos.org | yup | 15:31:03 |
sterni | unfortunately I think using the “oop” style of Perl is the only maintainable way | 15:35:42 |
sterni | since without enforcing an interface it is probably really hard to keep data structures consistent | 15:36:06 |
| cjbayliss (they/them) joined the room. | 22:13:05 |
| 8 Sep 2021 |
| mbprtpmnr joined the room. | 13:06:01 |
lukegb (he/him) | one of these days I'll fix the JS bug in the build dependencies tab | 19:28:09 |
lukegb (he/him) | (it's been broken since the change to load tab content dynamically, I think) | 19:28:21 |
@grahamc:nixos.org | what is that bug? | 19:52:00 |
lukegb (he/him) | the tree is supposed to collapse | 19:56:37 |
lukegb (he/him) | but it doesn't, because the JS only runs when the page loads and not when the tab loads | 19:56:47 |
das_j | wdym by collapse? | 19:58:00 |
das_j |  Download image.png | 19:58:13 |
lukegb (he/him) | as in, it's not supposed to show the entire tree at once :P | 19:58:24 |
das_j | for me it looks normal with the tree fully expanded and no way to collapse anything | 19:58:32 |
das_j | Did it ever do something else? | 19:58:37 |
lukegb (he/him) | right | 19:58:37 |
lukegb (he/him) | well, there's JS that tries to make it do something else | 19:58:49 |
das_j | Ah, learned something new today ;) | 19:59:10 |
lukegb (he/him) | https://hydra.nixos.org/static/js/common.js basically, you should be able to click on the sticky-out-bit of the line next to each thing to expand/collapse it | 19:59:36 |
lukegb (he/him) | maybe you're right and it never worked, though | 20:00:12 |
Rick (Mindavi) | Someone was working on a pr to make it collapsible | 20:00:47 |
ajs124 | das_j our version might just be too old for that feature | 20:00:58 |
das_j | oh | 20:01:07 |
Rick (Mindavi) | This one: https://github.com/NixOS/hydra/pull/906 | 20:02:14 |
das_j | feels like someone could just replace the `$(document).ready by something that is triggered when the tree is loaded (→ when the spinner is replaced) | 20:02:51 |