!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

367 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | āœ… merged šŸ‘€ reviewing āŒ needs work122 Servers

Load older messages


SenderMessageTime
30 Dec 2023
@realmchad:hackliberty.orgrealmchad joined the room.05:00:13
@a-n-n-a-l-e-e:matrix.org@a-n-n-a-l-e-e:matrix.orghttps://github.com/NixOS/nixpkgs/pull/277471 fixes compile error in curl configure script for ipv6 detection08:01:51
@getpsyched:matrix.orggetpsyched joined the room.13:27:35
@kiken_sr:matrix.orgKiken joined the room.16:08:19
@kiken_sr:matrix.orgKiken set a profile picture.16:09:03
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to@a-n-n-a-l-e-e:matrix.org
https://github.com/NixOS/nixpkgs/pull/277471 fixes compile error in curl configure script for ipv6 detection
Left one comment. The change looks good to me, though.
18:14:13
@niko:conduit.rsnyanbinary https://github.com/NixOS/nixpkgs/pull/272169 | nixos/network-interfaces: remove network-interfaces.target 18:21:40
@niko:conduit.rsnyanbinaryShould be ready to merge now?18:22:02
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to@a-n-n-a-l-e-e:matrix.org
https://github.com/NixOS/nixpkgs/pull/277471 fixes compile error in curl configure script for ipv6 detection
āœ…
18:40:43
@raitobezarius:matrix.orgraitobezarius changed their display name from raitobezarius (DECT 2128) to raitobezarius.19:52:48
31 Dec 2023
@niko:conduit.rsnyanbinaryhttps://github.com/NixOS/nixpkgs/pull/276396 | vinegar 1.5.9 -> 1.6.001:10:38
@niko:conduit.rsnyanbinary * https://github.com/NixOS/nixpkgs/pull/276396 | vinegar: 1.5.9 -> 1.6.001:10:47
@symphorien:xlumurb.eusymphorien https://github.com/NixOS/nixpkgs/pull/271030 nixseparatedebuginfo, package and module 14:21:37
@katexochen:matrix.orgPaul Meyer (katexochen)https://github.com/NixOS/nixpkgs/pull/274746 (tests included, 1 approval, needs merge)15:44:14
@trofi:matrix.orgtrofi pam 1.5.2 -> 1.5.3 update: https://github.com/NixOS/nixpkgs/pull/267447 17:07:08
@delroth:delroth.net@delroth:delroth.net
In reply to @trofi:matrix.org
pam 1.5.2 -> 1.5.3 update: https://github.com/NixOS/nixpkgs/pull/267447
really seems like something which should have a maintainer :/
17:23:19
@hexa:lossy.networkhexajust like the pam nixos module šŸ˜•17:23:53
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to@trofi:matrix.org
pam 1.5.2 -> 1.5.3 update: https://github.com/NixOS/nixpkgs/pull/267447
I saw you closed this without merging. What happened?
17:50:52
@philiptaron:matrix.orgPhilip Taron (UTC-8) changed their display name from Philip Taron to Philip Taron (UTC-8).18:10:41
@niko:conduit.rsnyanbinaryI didnt even know you could have a pamless system tbh18:57:51
@trofi:matrix.orgtrofi
In reply to @philiptaron:matrix.org
I saw you closed this without merging. What happened?
No sight of forward progress without a dedicated maintainer.
19:14:23
@hexa:lossy.networkhexadoesn't mean we shouldn't merge it as is19:17:16
@hexa:lossy.networkhexawe also don't have an active maintainer for e.g. curl19:17:33
@trofi:matrix.orgtrofiReopened.20:27:02
@philiptaron:matrix.orgPhilip Taron (UTC-8)

When I try to nixpkgs-review pr 267447, I get this:

$ nixpkgs-review pr 267447
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs staging:refs/nixpkgs-review/0 pull/267447/head:refs/nixpkgs-review/1
$ git worktree add /home/philip/.cache/nixpkgs-review/pr-267447-2/nixpkgs e86a9395174ac3f59e9809e20513729f09fbd177
Preparing worktree (detached HEAD e86a9395174a)
Updating files: 100% (38783/38783), done.
HEAD is now at e86a9395174a Merge pull request #277855 from r-ryantm/auto-update/rav1e
$ git merge --no-commit --no-ff c1b98c1879b181df11c2d263237b64d80f6d69f3
Auto-merging pkgs/os-specific/linux/pam/default.nix
Automatic merge went well; stopped before committing as requested
error:
       ā€¦ while calling the 'listToAttrs' builtin

         at /nix/store/wxla60xjdwdgq8kmkimsq8ssdp2jsbnk-nixpkgs-review-2.10.3/lib/python3.11/site-packages/nixpkgs_review/nix/evalAttrs.nix:46:1:

           45|
           46| listToAttrs (concatMap getProperties attrs)
             | ^
           47|

       ā€¦ while calling the 'concatMap' builtin

         at /nix/store/wxla60xjdwdgq8kmkimsq8ssdp2jsbnk-nixpkgs-review-2.10.3/lib/python3.11/site-packages/nixpkgs_review/nix/evalAttrs.nix:46:14:

           45|
           46| listToAttrs (concatMap getProperties attrs)
             |              ^
           47|

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: chia has been removed. see https://github.com/NixOS/nixpkgs/pull/270254
https://github.com/NixOS/nixpkgs/pull/267447 failed to build: nix --extra-experimental-features nix-command no-url-literals --system x86_64-linux eval --nix-path nixpkgs=/home/philip/.cache/nixpkgs-review/pr-267447-2/nixpkgs nixpkgs-overlays=/tmp/tmpaoruslly --json --impure --no-allow-import-from-derivation --expr (import /nix/store/wxla60xjdwdgq8kmkimsq8ssdp2jsbnk-nixpkgs-review-2.10.3/lib/python3.11/site-packages/nixpkgs_review/nix/evalAttrs.nix { attr-json = /tmp/tmpgt9i_o4d; }) failed to run, /tmp/tmpgt9i_o4d was stored inspection
$ git worktree remove -f /home/philip/.cache/nixpkgs-review/pr-267447-2/nixpkgs
22:06:30
@philiptaron:matrix.orgPhilip Taron (UTC-8)

Well, hrm. I really wanted to let my computer hum trying to compile most of staging and validate this PR for real.

@trofi, Iā€™m no stranger to C and Linux, but Iā€™m new-ish to Nix. Iā€™m debating taking up the maintainership for pam.

22:13:14
@trofi:matrix.orgtrofi error: chia has been removed sounds like you get an evaluation error on unrelated to pam package. Somethings possibly pulls in chia attribute. 22:32:48
@trofi:matrix.orgtrofi I'm not sure ix nixpkgs-review can handle PRs agains staging with huge rebuild count. I usually do these hacks to get a few reverse dependencies to validate: https://discourse.nixos.org/t/how-do-you-find-reverse-dependencies/15057 22:33:38
@trofi:matrix.orgtrofi * I'm not sure if nixpkgs-review can handle PRs agains staging with huge rebuild count. I usually do these hacks to get a few reverse dependencies to validate: https://discourse.nixos.org/t/how-do-you-find-reverse-dependencies/15057 22:33:53
@niko:conduit.rsnyanbinaryhttps://github.com/NixOS/nixpkgs/pull/216452 | dontAddToRubylib option23:14:50

There are no newer messages yet.


Back to Room ListRoom Version: 10