!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

461 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | ✅ merged 👀 reviewing ❌ needs work142 Servers

Load older messages


SenderMessageTime
30 Sep 2024
@phaer:matrix.orgphaerhttps://github.com/NixOS/nixpkgs/pull/34528321:05:03
@phaer:matrix.orgphaer^ package is currently broken on master since django got updated 21:05:40
@niklaskorz:korz.devNiklas Korzreviewed, tested and approved by 3 people, and ready to merge: https://github.com/NixOS/nixpkgs/pull/33905921:36:36
@cdombroski:kow.iscdombroskihttps://github.com/NixOS/nixpkgs/pull/33662322:06:39
@cdombroski:kow.iscdombroskihttps://github.com/NixOS/nixpkgs/pull/34264722:06:45
1 Oct 2024
@anderson_torres:matrix.orgAnderson Torreshttps://github.com/NixOS/nixpkgs/pull/344527 Nixfmt and other small things.00:21:49
@devusb:matrix.orgdevusbhttps://github.com/NixOS/nixpkgs/pull/34325801:28:26
@autra:trancart.euautra Sandro 🐧: for https://github.com/NixOS/nixpkgs/pull/312381 : I addressed your comments, please review again 🙏 07:18:00
@phanirithvij:matrix.orgloudgolemhttps://github.com/NixOS/nixpkgs/pull/345671 trivial package update16:42:33
@sarahec:matrix.orgSarah Clarkhttps://github.com/NixOS/nixpkgs/pull/345729 version bump, remove patch that was incorporated into this release18:52:28
@drupol:matrix.orgPolhttps://github.com/NixOS/nixpkgs/pull/345659 | jbigkit: add patches, fix security issue, build shared object19:00:30
@drupol:matrix.orgPol Thank you nim65s I fixed your suggestion. 19:35:50
@-_o:matrix.org-_o joined the room.20:56:14
@tomasajt:matrix.orgTomahttps://github.com/NixOS/nixpkgs/pull/303865 ^ init a dotnet based git gui app22:36:50
2 Oct 2024
@sarahec:matrix.orgSarah ClarkFixes a broken test in langchain-chroma that is blocking @fabaff's chromadb update. 00:59:08
@sarahec:matrix.orgSarah Clark * Fixes a broken test in langchain-chroma that is blocking @fabaff's chromadb update. https://github.com/NixOS/nixpkgs/pull/34580300:59:17
@hexa:lossy.networkhexa Sarah Clark: send the patch upstream and fetch it from there 01:26:54
@hexa:lossy.networkhexa * Sarah Clark: fetchpatch the patch you sent upstream 01:27:56
@lumbo7332:matrix.orgPope_Rigbyhttps://github.com/NixOS/nixpkgs/pull/34123904:58:13
@drupol:matrix.orgPol nim65s: Could you validate it again? I got some feedback from the Darwin maintainers and added meta.broken attribute. => https://github.com/NixOS/nixpkgs/pull/345659 10:05:16
@flx-:matrix.orgflxA small one https://github.com/NixOS/nixpkgs/pull/34561712:25:15
@gsaurel:laas.frnim65s flx: that one is 2d old, please leave it more time before pinging here. Also, this is effectively doing the opposite of what you claim. By default, it is only exposed to localhost, and in that PR, you add a default to 0.0.0.0 which is all interfaces. 13:27:02
@flx-:matrix.orgflx
In reply to @gsaurel:laas.fr
flx: that one is 2d old, please leave it more time before pinging here. Also, this is effectively doing the opposite of what you claim. By default, it is only exposed to localhost, and in that PR, you add a default to 0.0.0.0 which is all interfaces.
It's not listening to localhost by default, but to 0.0.0.0.
13:30:09
@flx-:matrix.orgflxI'm running a Redmine without that parameter.13:30:27
@flx-:matrix.orgflxI just checked.13:30:30
@flx-:matrix.orgflx * I just checked again.13:30:48
@emilazy:matrix.orgemily(best to keep discussion on the PR)13:35:47
@noahgitsham:matrix.orgNoah changed their display name from Noah GITsham to Noah.13:40:59
@frontear:matrix.orgfrontear joined the room.18:40:45
3 Oct 2024
@sarahec:matrix.orgSarah Clark
In reply to @hexa:lossy.network
Sarah Clark: fetchpatch the patch you sent upstream
Normally yes, but they're being very slow to merge.
00:51:48

Show newer messages


Back to Room ListRoom Version: 10