!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

470 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | ✅ merged 👀 reviewing ❌ needs work145 Servers

Load older messages


SenderMessageTime
17 Oct 2024
@joerg:thalheim.ioMic92 changed their display name from Mic92 to Mic3000.06:51:17
@joerg:thalheim.ioMic92 changed their display name from Mic3000 to Mic3000 🌋.06:51:46
@teutat3s:pub.solarteutat3sdocker 27 backport https://github.com/NixOS/nixpkgs/pull/34863211:46:50
@joerg:thalheim.ioMic92 changed their display name from Mic3000 🌋 to Mic92.12:22:31
@titaniumtown:envs.nettitaniumtown (they/them) joined the room.14:42:19
@titaniumtown:envs.nettitaniumtown (they/them)gpt4all version bump: https://github.com/NixOS/nixpkgs/pull/34618514:42:27
@gvolpe:matrix.orggvolpehttps://github.com/NixOS/nixpkgs/pull/34687815:50:00
@teutat3s:pub.solarteutat3sSmall docs change: https://github.com/NixOS/nixpkgs/pull/18143616:46:56
@emilazy:matrix.orgemily
In reply to @teutat3s:pub.solar
Small docs change: https://github.com/NixOS/nixpkgs/pull/181436
points to the old wiki
17:05:26
@emilazy:matrix.orgemily(I think we avoid linking the wiki from official docs in general - not sure - but that one definitely won't fly)17:06:09
@nishimara:nishimara.comNishimarahttps://github.com/NixOS/nixpkgs/pull/34816017:10:11
@6pak:matrix.org6pak joined the room.17:11:21
@kttmm:matrix.orgkototamaHi everyone, how can I get my MR (https://github.com/NixOS/nixpkgs/pull/346496) merged? It has been review but not merged. It's already two weeks now. I have posted it also on the forum but no success :-(17:12:48
@teutat3s:pub.solarteutat3sI can find min. 4 references to external wikis in the NixOS manual. So we have precedents 😄17:22:39
@perpetrator1:matrix.orgmuneer joined the room.17:25:20
@teutat3s:pub.solarteutat3s * I can find min. 4 references to external wikis in the NixOS manual. So we have precedents 😄
EDIT: ooh you meant the nixos wiki.
17:27:44
@zzywysm:matrix.orgzzywysm joined the room.17:30:54
@teutat3s:pub.solarteutat3sHa, Impermanence links to wiki.nixos.org :P17:40:39
@teutat3s:pub.solarteutat3s
In reply to @emilazy:matrix.org
points to the old wiki
Fixed in https://github.com/NixOS/nixpkgs/pull/349344
21:33:17
18 Oct 2024
@gvolpe:matrix.orggvolpehttps://github.com/NixOS/nixpkgs/pull/346878 anyone able to merge? this is critical for my team at work and not everyone is skilled with overlays and custom nixpkgs instances 🙏08:12:39
@etcpanda:matrix.orgetcpandahttps://github.com/NixOS/nixpkgs/pull/318600 | nixos/iosched: init module09:44:46
@niko:nyanbinary.rsnyanbinary 🏳️‍⚧️https://github.com/NixOS/nixpkgs/pull/277016 | nixos/nat: Match iptables behavior with nftables, add externalIP check With the feature freeze coming up soon can someone merge this? :P11:34:20
@greg:thehellings.comgreghttps://github.com/NixOS/nixpkgs/pull/349540 | a tweak to the build function for libcurl allowing overriding static/shared builds. It does not appear to actually trigger any rebuilds or changes, which was my goal, but rather to make the shared/static linkage be an option13:58:00
@greg:thehellings.comgreg
In reply to @greg:thehellings.com
https://github.com/NixOS/nixpkgs/pull/349540 | a tweak to the build function for libcurl allowing overriding static/shared builds. It does not appear to actually trigger any rebuilds or changes, which was my goal, but rather to make the shared/static linkage be an option
Looks like ofBorg agrees that no actual rebuilds will be triggered by this. So that's awesome
15:33:56
@kjeremy:matrix.orgkjeremy joined the room.15:35:20
@kjeremy:matrix.orgkjeremyCan I get a review of https://github.com/NixOS/nixpkgs/pull/347939?15:35:49
@frontear:matrix.orgfrontear I'd appreciate a review for both https://github.com/NixOS/nixpkgs/pull/342961 and https://github.com/NixOS/nixpkgs/pull/349567. Both PRs were originally one, but were separated to make testing easier at the request of Tristan Ross . In particular, I'd appreciate if people with strong builders can run testing on the former PR, as that contains the major rebuilds which I can no longer build in a timely fashion. 16:39:53
@cdombroski:kow.iscdombroskihttps://github.com/NixOS/nixpkgs/pull/33662320:55:53
@jopejoe1:matrix.orgjopejoe1https://github.com/NixOS/nixpkgs/pull/33470721:04:41
@greg:thehellings.comgreg
In reply to @frontear:matrix.org
I'd appreciate a review for both https://github.com/NixOS/nixpkgs/pull/342961 and https://github.com/NixOS/nixpkgs/pull/349567. Both PRs were originally one, but were separated to make testing easier at the request of Tristan Ross . In particular, I'd appreciate if people with strong builders can run testing on the former PR, as that contains the major rebuilds which I can no longer build in a timely fashion.
So far I've built 330 and have 230 left in that first PR. gnome-control-center failed to build, so far. Otherwise, the rest have been successful
22:39:52

Show newer messages


Back to Room ListRoom Version: 10