!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

462 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | ✅ merged 👀 reviewing ❌ needs work143 Servers

Load older messages


SenderMessageTime
14 Oct 2024
@madisetti:matrix.orgdylanhttps://github.com/NixOS/nixpkgs/pull/348012 🙂20:19:48
@niko:nyanbinary.rsnyanbinary 🏳️‍⚧️https://github.com/NixOS/nixpkgs/pull/339802 | nixos/etc-overlay: clean up temporary directories21:46:39
15 Oct 2024
@niko:nyanbinary.rsnyanbinary 🏳️‍⚧️https://github.com/NixOS/nixpkgs/pull/305628 | check-cherry-picks.sh: "pass" commit differences but post check-run with warning00:09:56
@niko:nyanbinary.rsnyanbinary 🏳️‍⚧️ * https://github.com/NixOS/nixpkgs/pull/305628 | check-cherry-picks.sh: "pass" commit differences but post check-run with warning 00:10:04
@pyrox:pyrox.devdish [Fox/It/She] joined the room.02:33:03
@pyrox:pyrox.devdish [Fox/It/She] left the room.02:34:06
@pyrox:pyrox.devdish [Fox/It/She] joined the room.02:35:20
@pyrox:pyrox.devdish [Fox/It/She] changed their display name from Pyrox [Fox/It/She] to dish [Fox/It/She].03:16:35
@galaxyyy:matrix.orgSaturn joined the room.03:18:44
@galaxyyy:matrix.orgSaturnhttps://github.com/NixOS/nixpkgs/pull/348133 | Approved by package maintainer. Anyone able to merge?03:19:37
@sigmasquadron:matrix.orgSigmaSquadron
In reply to @galaxyyy:matrix.org
https://github.com/NixOS/nixpkgs/pull/348133 | Approved by package maintainer. Anyone able to merge?
Give it a couple of days.
03:20:54
@sigmasquadron:matrix.orgSigmaSquadron
In reply to @galaxyyy:matrix.org
https://github.com/NixOS/nixpkgs/pull/348133 | Approved by package maintainer. Anyone able to merge?
*

Give it a couple of days.

Have a PR that is ready for review but remains unreviewed for a week or longer?

03:21:27
@galaxyyy:matrix.orgSaturn
In reply to @sigmasquadron:matrix.org

Give it a couple of days.

Have a PR that is ready for review but remains unreviewed for a week or longer?

My bad I didn't see that description, was hidden on my client
03:25:53
@dgrig:erethon.comdgrighttps://github.com/NixOS/nixpkgs/pull/344746 | Not sure if this is something we want to merge, there are two similar PRs open (linked in the PR) that haven't moved in a while too.09:05:07
@phanirithvij:matrix.orgloudgolemhttps://github.com/NixOS/nixpkgs/pull/348729 approved by maintainer, simple bump11:16:51
@phanirithvij:matrix.orgloudgolem * https://github.com/NixOS/nixpkgs/pull/348729 approved by maintainer, simple bump11:17:14
@squalus0:matrix.orgsqualus joined the room.16:03:27
@liff:matrix.orgollijh joined the room.16:28:04
@liff:matrix.orgollijhhttps://github.com/NixOS/nixpkgs/pull/270209 maintainer is not in the nixpkgs maintainers team, so cannot request a review18:15:57
@squalus0:matrix.orgsqualusHi, I have two PRs for osquery. One updates to a newer version (https://github.com/NixOS/nixpkgs/pull/342807), and one removes a bug workaround that's not needed anymore (https://github.com/NixOS/nixpkgs/pull/343084)19:02:42
@rosscomputerguy:matrix.orgTristan Ross
In reply to @squalus0:matrix.org
Hi, I have two PRs for osquery. One updates to a newer version (https://github.com/NixOS/nixpkgs/pull/342807), and one removes a bug workaround that's not needed anymore (https://github.com/NixOS/nixpkgs/pull/343084)
Probably could do the workaround removal in the update one
19:12:07
16 Oct 2024
@jee_mj:matrix.orgmj joined the room.00:34:09
@jee_mj:matrix.orgmj

Hi, it’s been two weeks since this pull request has passed all tests without any activity. I was wondering if someone could have a look at it and potentially move things along.

https://github.com/NixOS/nixpkgs/pull/345820

00:35:48
@ihar.hrachyshka:matrix.orgIhar Hrachyshka joined the room.00:40:36
@jee_mj:matrix.orgmjIt’s using the proof-of-concept because it’s very new. Later there could be a different repo/vendor that implements the technology in a more frequently maintained package. Actually, when I compare it to something like bitcoin which was originally just a proof, it might just become the normal package to use. Currently integrates with an NGINX/PHP backend with ease.00:46:38
@tobim:matrix.orgtobimPacking Azure-sdk-for-cpp: https://github.com/NixOS/nixpkgs/pull/348202 The packaging is a bit more involved because it is a superproject consisting of many components. Some feedback about the approach would be very welcome.10:10:48
@catalin:one.ems.hostViorel-Cătălin RăpițeanuCan someone that has Gnome desktop test if this is working as expected? https://github.com/NixOS/nixpkgs/pull/34891817:21:00
@vengmark2:matrix.orgl0b0https://github.com/NixOS/nixpkgs/pull/25988019:16:48
@ners:nixos.dev@ners:nixos.devhttps://github.com/NixOS/nixpkgs/pull/347704 Pretty trivial version bump21:32:11
@colin:uninsane.orgColin joined the room.22:14:16

Show newer messages


Back to Room ListRoom Version: 10