!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

462 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | ✅ merged 👀 reviewing ❌ needs work143 Servers

Load older messages


SenderMessageTime
9 Oct 2024
@jackwilsdon:matrix.orgjackwilsdon * https://github.com/NixOS/nixpkgs/pull/335867 - has a review comment on it but I've left a reply and didn't hear back, so it'd be good to get some more opinions on it please 😁21:53:56
10 Oct 2024
@drupol:matrix.orgPol
In reply to @jackwilsdon:matrix.org
https://github.com/NixOS/nixpkgs/pull/335867 - has a review comment on it but I've left a reply and didn't hear back, so it'd be good to get some more opinions on it please 😁
I agree with makeBinaryWrapper.
08:33:38
@jackwilsdon:matrix.orgjackwilsdonSweet cheers, I'll add that (and the set +u).09:36:23
@lars:familie-vogdt.dekl_eisbaer joined the room.16:56:17
@atalii:matrix.orgtali joined the room.19:55:17
@atalii:matrix.orgtaliWould appreciate someone looking at this version bump - https://github.com/NixOS/nixpkgs/pull/34758219:56:17
@catalin:one.ems.hostViorel-Cătălin RăpițeanuDoes someone uses ProtonVPN? If so, can you try and review this PR: https://github.com/NixOS/nixpkgs/pull/343204 The ProtonVPN team unified a ton of packages so it's quite a bit to review. For now I've tested on my side and everything worked as expected for all my use cases.21:35:19
@wizardlink:matrix.orgwizardlink joined the room.22:58:00
@greg:thehellings.comgreg joined the room.23:32:57
11 Oct 2024
@98765abc:mozilla.org98765abc changed their profile picture.01:57:55
@teutat3s:pub.solarteutat3s This should be a quick one
https://github.com/NixOS/nixpkgs/pull/347064
06:36:04
@julian_fp:matrix.org@julian_fp:matrix.org joined the room.17:31:31
@amy:catgirl.cloudAmy joined the room.19:41:43
@niko:nyanbinary.rsnyanbinary 🏳️‍⚧️https://github.com/NixOS/nixpkgs/pull/346379 | zepp-simulator: init at 2.0.220:29:50
12 Oct 2024
@federicodschonborn:matrix.orgFederico Damián Schonborn changed their profile picture.00:31:08
@julian_fp:matrix.org@julian_fp:matrix.org left the room.03:02:51
@etcpanda:matrix.orgetcpandahttps://github.com/NixOS/nixpkgs/pull/318600 | nixos/iosched: init module11:22:47
@tom:dragar.deTomWould be nice for me to have this backport into stable. Thanks! https://github.com/NixOS/nixpkgs/pull/34770912:17:12
@donteatoreo:matrix.orgOreoformated, fixed darwin, bumped darwin and refactored meta green ci/cd https://github.com/NixOS/nixpkgs/pull/34731315:12:43
13 Oct 2024
@bot-wxt1221:matrix.orgBot_wxt1221 joined the room.03:31:22
@gsaurel:laas.frnim65shttps://github.com/NixOS/nixpkgs/pull/334150 | doxygen: 1.10.0 -> 1.12.0 + python3Packages.doxmlparser: init at 1.12.009:32:07
@catalin:one.ems.hostViorel-Cătălin RăpițeanuCan someone help me with this PR? https://github.com/NixOS/nixpkgs/pull/34693212:38:35
@jackwilsdon:matrix.orgjackwilsdonhttps://github.com/NixOS/nixpkgs/pull/335867 - turns out we can't use makeBinaryWrapper for this, could someone please take a look and let me know if there's anything else that needs changing?13:07:21
@opna2608:matrix.orgPunahttps://github.com/NixOS/nixpkgs/pull/347177 | pmars: init at 0.9.414:07:38
@sigmasquadron:matrix.orgSigmaSquadronhttps://github.com/NixOS/nixpkgs/pull/342692 | seabios refactors14:58:44
14 Oct 2024
@emilazy:matrix.orgemilyhttps://github.com/NixOS/nixpkgs/pull/34697701:23:58
@melvyn2:matrix.orgmelvyn2https://github.com/NixOS/nixpkgs/pull/34843004:46:20
@tomasajt:matrix.orgTomahttps://github.com/NixOS/nixpkgs/pull/303865 ^ init dotnet based git gui app06:41:14
@jaredbaur:matrix.orgJared Baurhttps://github.com/NixOS/nixpkgs/pull/34670211:09:23
@gvolpe:matrix.orggvolpeAnyone able to review/merge? One approval, open for +1 week 🙏 https://github.com/NixOS/nixpkgs/pull/34687816:41:45

Show newer messages


Back to Room ListRoom Version: 10