!zihVdbsMjkhRfMQMXv:nixos.org

Nixpkgs Review Requests

703 Members
Have a PR that is ready for review but remains unreviewed for a week or longer? Post it here! | Allow package maintainers a few days to respond | Reviews are not guaranteed, as most of us are volunteers | ✅ merged 👀 reviewing ❌ needs work201 Servers

Load older messages


SenderMessageTime
25 Apr 2025
@philipdb:matrix.orgPhiliPdB set a profile picture.12:32:10
@gsaurel:laas.frnim65shttps://github.com/NixOS/nixpkgs/pull/395016 | python3Packages.nanoneigenpy: init at 0.1.0  This will become a dependency of multiple packages I maintain15:02:09
@ofalvai:matrix.orgofalvaiA simple improvement: https://github.com/NixOS/nixpkgs/pull/40030218:19:45
@ofalvai:matrix.orgofalvaiA fix of a previous typo I made: https://github.com/NixOS/nixpkgs/pull/40031518:20:35
@rosscomputerguy:matrix.orgTristan Rosshttps://github.com/NixOS/nixpkgs/pull/391962 https://github.com/NixOS/nixpkgs/pull/391695 https://github.com/NixOS/nixpkgs/pull/37840518:28:27
@rosscomputerguy:matrix.orgTristan Rosshttps://github.com/NixOS/nixpkgs/pull/365057 https://github.com/NixOS/nixpkgs/pull/330037 https://github.com/NixOS/nixpkgs/pull/32999518:31:10
@nullcube:matrix.orgNullCubeI'll throw these here, I'd like to get these two merged before 25.05 (and backported to 24.11 tbh) as they fix a couple decently prominent issues with the Anubis module that was added a couple weeks ago: https://github.com/NixOS/nixpkgs/pull/398790 | nixos/anubis: Fix defaultOptions not applying user-defined settings https://github.com/NixOS/nixpkgs/pull/401622 | nixos/anubis: Add missing botPolicy option implementation (This is a draft but that's just for now for merge conflict reasons, I'd appreciate some reviews on if I'm doing the right thing here regardless)20:05:23
@nullcube:matrix.orgNullCube* I'll throw these here, I'd like to get these two merged before 25.05 (and backported to 24.11 tbh) as they fix a couple decently prominent issues with the Anubis module that was added a couple weeks ago: https://github.com/NixOS/nixpkgs/pull/398790 | nixos/anubis: Fix defaultOptions not applying user-defined settings https://github.com/NixOS/nixpkgs/pull/401622 | nixos/anubis: Add missing botPolicy option implementation (This is a draft and also pretty recent, draft is just for now for merge conflict reasons, I'd appreciate some reviews on if I'm doing the right thing here regardless)20:06:09
26 Apr 2025
@xiaoxiangmoe:matrix.org🐰 xiaoxiangmoehttps://github.com/NixOS/nixpkgs/pull/39738703:23:25
@oddlama:matrix.orgoddlamahttps://github.com/NixOS/nixpkgs/pull/399498 | simple package update09:30:56
@britter:yatrix.orgBenedikt Ritter (britter)Improved a test for the gradle package, no functional changes, approval from package maintainger: https://github.com/NixOS/nixpkgs/pull/39596510:32:08
@programmer_jarvis:matrix.orgPROgrm_JARvishttps://github.com/NixOS/nixpkgs/pull/398333 -- simple package update12:31:35
@programmer_jarvis:matrix.orgPROgrm_JARvishttps://github.com/NixOS/nixpkgs/pull/394440 -- new trivial package12:59:23
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)

Hoping to get some traction on this simple but necessary QoL improvement for CMake.

https://github.com/NixOS/nixpkgs/pull/379426

13:32:11
@stephen:crabsin.spaceStephen D This should be good to merge, has 2 approvals: https://github.com/NixOS/nixpkgs/pull/400095 14:17:38
@stephen:crabsin.spaceStephen D This one I'm less sure about but I'd love a review: https://github.com/NixOS/nixpkgs/pull/400088 14:17:50
@drupol:matrix.orgPolAdded a review14:49:40
@drupol:matrix.orgPolA comment from a reviewer was not addressed: https://github.com/NixOS/nixpkgs/pull/400095/files#r205158539214:51:49
@drupol:matrix.orgPol Added a comment about DynamicUser. 14:53:17
@stephen:crabsin.spaceStephen D
In reply to @drupol:matrix.org
A comment from a reviewer was not addressed: https://github.com/NixOS/nixpkgs/pull/400095/files#r2051585392
grr, I think that was a bad merge on my part
15:14:52
@stephen:crabsin.spaceStephen DShould be good now15:15:39
@bumperboat:matrix.orgbumperboathttps://github.com/NixOS/nixpkgs/pull/401460 maybe easy pickens ? i dunno maybe systemd has more overview, but its just dox anyway15:56:09
@programmer_jarvis:matrix.orgPROgrm_JARvisThanks! All addresses (just pushed the updated commit)16:25:00
@donteatoreo:matrix.orgOreohttps://github.com/NixOS/nixpkgs/pull/375010 | shottr: init at 1.8.1 https://github.com/NixOS/nixpkgs/pull/396069 | soundsource: 5.7.5 -> 5.8.217:10:10
@debaa:matrix.orgdebabrata pattnayak joined the room.18:05:03
@theredstonedev_de:matrix.devellight.spaceTheRedstoneDEV_DERedacted or Malformed Event19:08:19
@awwpotato:envs.netawwpotato (she/her) changed their profile picture.19:52:46
@awwpotato:envs.netawwpotato (she/her)pretty simple move to by-name https://github.com/NixOS/nixpkgs/pull/39986320:17:55
@voxel:nyanbinary.rsvoxel 🏳️‍⚧️

https://github.com/NixOS/nixpkgs/pull/396644

pixieditor

20:48:06
@voxel:nyanbinary.rsvoxel 🏳️‍⚧️ *

https://github.com/NixOS/nixpkgs/pull/396644

pixieditor v2.0 linux open beta

20:55:01

Show newer messages


Back to Room ListRoom Version: 10