| 16 Feb 2025 |
|  aloisw changed their profile picture. | 10:14:36 |
 K900 | @ElvishJerricco @infinisil FYI https://github.com/NixOS/nixpkgs/commit/daadcbdaacc352a2031d53eaf6f8f1eedc263bcb | 16:42:55 |
 ElvishJerricco | I could swear we already had that... | 16:43:35 |
| K900 | We had pkgs.bash | 16:43:45 |
| K900 | And on staging-next pkgs.bash == pkgs.bashInteractive | 16:43:51 |
| K900 | And pkgs.runtimeShell = ${pkgs.bashNonInteractive}/bin/bash | 16:43:59 |
 infinisil | In reply to @k900:0upti.me
@ElvishJerricco @infinisil FYI https://github.com/NixOS/nixpkgs/commit/daadcbdaacc352a2031d53eaf6f8f1eedc263bcb Nice, thanks | 16:46:47 |
| ElvishJerricco | K900: oh, like pkgs.bash was changed to bashInteractive? Why? | 16:48:52 |
| K900 | Convenience, primarily | 16:49:10 |
| K900 | @infinisil's PR has detailed motivation | 16:49:19 |
| K900 | That I generally agree with | 16:49:24 |
| ElvishJerricco | link? | 16:49:40 |
| K900 | Hold on need to find it | 16:50:11 |
| K900 | Currently rolling back all the shit I just made not boot | 16:50:24 |
| infinisil | ElvishJerricco: https://github.com/NixOS/nixpkgs/pull/379368 | 16:50:36 |
| ElvishJerricco | K900: But ok, that probably means the "${pkgs.bash}/bin" that comes after is no longer correct | 16:50:39 |
| K900 | We have both anyway | 16:50:59 |
| ElvishJerricco | Because we only have that there for the packages that use #!..../bin/sh | 16:51:00 |
| K900 | Yeah I wasn't sure | 16:51:16 |
| K900 | About the second XFS big | 16:51:20 |
| K900 | * About the second XFS bit | 16:51:21 |
| ElvishJerricco | Yea but it still seems probably more correct to somehow get the sh variant of runtimeShell | 16:51:40 |
| ElvishJerricco | but it doesn't really matter | 16:51:50 |
| K900 | Is it? | 16:51:50 |
| K900 | I don't think it is tbh | 16:51:53 |
| K900 | runtimeShell is an stdenv concept | 16:51:57 |
| K900 | It doesn't have to be your /bin/sh | 16:52:03 |
| ElvishJerricco | K900: I guess it depends on why things like xfs were ending up with sh as their interpreter. I imagine they were just using patchShebangs, and I don't know where it would find sh from | 16:52:41 |
| K900 | Ambient stdenv presumably | 16:53:05 |
| ElvishJerricco | yea so realistically we would want the logic in storePaths to mirror whatever patchShebangs is doing to find sh | 16:54:37 |
