| 7 Dec 2021 |
 Thib |
Do not try and bend the spoon room – that's impossible. Instead only try to realise the truth. There is no spoon room.
| 15:03:06 |
| 9 Dec 2021 |
|  andrew left the room. | 14:25:06 |
|  Janne Heß joined the room. | 20:39:55 |
|  jbedo joined the room. | 21:33:44 |
| 13 Dec 2021 |
|  Enzime joined the room. | 00:02:29 |
| Enzime | have there been any thoughts about making a PR channel where you can request a review for your PR? | 00:11:25 |
| Enzime | similar to the #pr-review-request on the unofficial NixOS Discord | 00:11:28 |
 adisbladis | In reply to @enzime:nixos.dev
have there been any thoughts about making a PR channel where you can request a review for your PR? Tbh I don't think you would get many participants with commit bit | 00:25:20 |
| adisbladis | It's not like we are not reviewing PRs for the fun of it | 00:25:38 |
 hexa | yeah, it's mostly for a lack of (motivation|time) | 00:25:57 |
| adisbladis | From a person with commit bits perspective: Such a channel is purely spam | 00:26:08 |
| Enzime | adisbladis: what would you suggest for finding someone to review your PR, I remember on IRC posting my PR in the general chat was the best way to do it | 00:27:59 |
| adisbladis | In reply to @enzime:nixos.dev
adisbladis: what would you suggest for finding someone to review your PR, I remember on IRC posting my PR in the general chat was the best way to do it Look at git history and ping relevant previous authors on github | 00:28:32 |
| hexa | maintainers should be the first contact for a review | 00:28:36 |
| hexa | sadly our maintainers situation is less than ideal | 00:28:46 |
| Enzime | and it might be nice to separate those out to a different channel so that even if everyone had it permanently muted when people have a moment they could just look at a few PRs posted | 00:29:12 |
| adisbladis | The "best" way for you perphaps, but as for the project as a whole it would be immensely annoying to constantly get pinged by PR authors in side channels | 00:29:30 |
| adisbladis | The current situation isn't ideal | 00:29:58 |
| hexa | best case: you find others who share your interest in the package and the git history is a good starting point for that | 00:30:22 |
| adisbladis | I mean... Github notifications is already spammy to the the point of being useless | 00:30:31 |
| Enzime | yeah at my day job, the solution we landed on was just posting PR links in Slack when they needed reviewing, and it seems to work alright | 00:31:05 |
 Zhaofeng Li | For "side channels," there are "PRs ready for review" threads on Discourse. | 00:31:12 |
| hexa | that really depends on what you maintain or are codeowner for | 00:31:18 |
| adisbladis | In reply to @enzime:nixos.dev
yeah at my day job, the solution we landed on was just posting PR links in Slack when they needed reviewing, and it seems to work alright For a company where reviewers are paid it's an entirely different thing | 00:31:24 |
| Enzime | oh yep, forgot about the Discourse thread | 00:31:27 |
| hexa | for home automation related things i usually post open prs on the on-topic matrix room, without much success sadly | 00:32:01 |
| hexa | same happens on other channels (matric ecosystem, systemd, … security :)) | 00:32:22 |
| hexa | but that doesn't really scale well either | 00:33:35 |
| adisbladis | hexa: At least that is somewhat distributed | 00:33:52 |
| hexa | can't do the same for a channel that is related to a package set, unless the change is on a critical path | 00:33:54 |
