!UUYziobKGGxpovWyAN:nixos.org

Robotnix

248 Members
Build Android (AOSP) using Nix | https://github.com/danielfullmer/robotnix76 Servers

Load older messages

SenderMessageTime
26 Mar 2024
@eyjhb:eyjhb.dkeyJhb
In reply to @atemu12:matrix.org
The prebuilt version would be hopelessly out of date anyways
* Doesn't it follow lineageos? 		20:12:41
@eyjhb:eyjhb.dkeyJhbI wonder why it isn't in the folder anymore20:15:31
@eyjhb:eyjhb.dkeyJhbAh, new issue20:44:56
@eyjhb:eyjhb.dkeyJhbfetchLFS should be enabled for external it seems. Otherwise prebuilt will not work20:45:09
@samueldr:matrix.orgsamueldr
In reply to @eyjhb:eyjhb.dk
Well well well, that's one way of showing no interest in Robotnix! /s ( hexa ) :D
I asked in the matrix suggestions room to fix the state :) 		20:49:30
@eyjhb:eyjhb.dkeyJhbYeah I saw it, just poking fun at it :)20:49:48
@eyjhb:eyjhb.dkeyJhbGetting infinite recursion when I set fetchLFS = true. Well that seems fun20:51:23
@eyjhb:eyjhb.dkeyJhb

But it seems like in flavors/lineageos/default.nix , this should be set instead

  webview.prebuilt.apk = if config.androidVersion >= 11 then
    config.source.dirs."external/chromium-webview/prebuilt/${config.arch}".src + "/webview.apk"
  else
    config.source.dirs."external/chromium-webview".src + "/prebuilt/${config.arch}/webview.apk";
20:53:34
@eyjhb:eyjhb.dkeyJhbBut the new issue is, that file is just some LFS junk, and it needs to be fetched correctly ( https://github.com/LineageOS/android_external_chromium-webview_prebuilt_arm64/blob/main/webview.apk )20:54:00
@eyjhb:eyjhb.dkeyJhb 
      # LineageOS will sometimes force-push to this repo, and the older revisions are garbage collected.
      # So we'll just build chromium webview ourselves.
      "external/chromium-webview".enable = false;
20:54:50
@eyjhb:eyjhb.dkeyJhbAnd I guess that should be changed as well.20:54:56
@eyjhb:eyjhb.dkeyJhbNo clue, need assistance if I am to look further at it. But before the prebuilt webviews can work again, the mk_repo_file.py needs to do lfs, and the pkgs.fetchgit needs to add lfs support as well. AFAIK the manifest does not specify if LFS is needed..21:34:50
@eyjhb:eyjhb.dkeyJhbBut then again, https://github.com/LineageOS/android/blob/lineage-20.0/default.xml i'm not sure where the chromium prebuilt comes from, in which manifest21:35:24
@eyjhb:eyjhb.dkeyJhbhttps://github.com/remote-android/platform_manifests/blob/redroid-11.0.0/external.xml#L7 oh, maybe it does. If I could find the correct manifest21:36:35
27 Mar 2024
@admin:nixos.org@admin:nixos.org left the room.04:07:20
@eyjhb:eyjhb.dkeyJhbWell, I think I've patched most of robotnix to allow LFS now. It shouldn't really change much, as if a repo is not using LFS, it will give the same hash either way (LFS enabled or disabled). :)08:28:26
@eyjhb:eyjhb.dkeyJhbSlowly learning how the source code works.08:28:33
@eyjhb:eyjhb.dkeyJhbhttps://github.com/nix-community/robotnix/pull/228 initial work here09:02:35
@eyjhb:eyjhb.dkeyJhb So prebuilt webview seems to be working with that PR. I haven't updated all sources and tested (takes ages), but I updated enough to get the new correct prebuilt webviews w/ LFS, and just copy pasted that over in the repo.json :) 09:08:04
@atemu12:matrix.orgatemu12Thanks a bunch. I don't know when/if I will have time to take a look though10:42:43
@eyjhb:eyjhb.dkeyJhb
In reply to @atemu12:matrix.org
Thanks a bunch. I don't know when/if I will have time to take a look though
Understandable. Is the other maintainer all out of spoons as well? 		11:04:05
@eyjhb:eyjhb.dkeyJhbI've just built a new image, with the prebuilt APKs. Haven't tested it yet. It would be more ideal if I had 2x phones :p11:04:25
@eyjhb:eyjhb.dkeyJhb 
        # Workaround name inconsistency with LG
        if vendor == 'lg':
            vendor = 'lge'
        # Look how cool my name is mom, parenthesis!
        if vendor == 'f(x)tec':
            vendor = 'fxtec'
        # Urgh
        if vendor == '10.or':
            vendor = '10or'
        # Really?
        if vendor == 'banana pi':
            vendor = 'bananapi'
12:40:54
@eyjhb:eyjhb.dkeyJhb

Appreciate the comments :p

Look how cool my name is mom, parenthesis!

12:41:08
@eyjhb:eyjhb.dkeyJhb *

Appreciate the comments :p

Look how cool my name is mom, parenthesis!

12:41:11
@atemu12:matrix.orgatemu12:p12:44:43
@eyjhb:eyjhb.dkeyJhbI haven't dared to flash my FP4 yet. But I still want to see if the prebuilt browser thing works. :D Right now I'm just investigating if LineageOS 21.0 would be "easily" doable. But at the same time, I also just want to nuke all the building of chromium12:46:01
@eyjhb:eyjhb.dkeyJhb Atemu: this might be a bad solution, but could it make sense to have a "dev" branch, where the various PRs could be merged into, as to not touch master too much. E.g. if you don't have the time to DEEPLY look into if a PR should be merged, then having a 2nd branch might make sense? Just a thought, and most likelly a bad thought. 12:46:51
@atemu12:matrix.orgatemu12Nah, I'd rather just review and put things into master12:47:15
@atemu12:matrix.orgatemu12It's not like there are many users either; you can probably count them on 0-1 hands12:47:35

Show newer messages

Back to Room ListRoom Version: 6