| 7 Sep 2021 |
danielrf | yep | 00:50:37 |
kranzes | So i can just remove it from the flake.nix | 00:50:42 |
kranzes | No need to manually enable it | 00:50:48 |
kranzes |  Download Screenshot_20210907-035309400.jpg | 00:53:20 |
kranzes | 👍 | 00:53:24 |
kranzes | Once we figure out what's causing this issue we can take a look at the src of forklineageos and check if we can modify it so we won't need to disable anything already in robotnix | 00:55:11 |
kranzes | Maybe something is off there | 00:55:19 |
kranzes | danielrf good news, it boots with reproducibility fixes enabled | 15:33:42 |
kranzes | So it's either the vendor patch or APEX | 15:33:55 |
danielrf | Well, there's no code differences between lineageos and forklineageos's versions of "vendor/lineage", so if our patches are causing the issue, there must be some other difference elsewhere which is contributing. | 19:35:00 |
kranzes | 99% done on building with the vendor/lineage patches | 19:42:10 |
kranzes | I'll update you if that works | 19:42:25 |
kranzes | if that still works than it has to be the APEX stuff i think | 19:42:30 |
danielrf | It would also would be a surprising if that was the cause, since APEX packages are flattened in upstream LineageOS... | 19:43:11 |
danielrf | but let's see! | 19:43:15 |
kranzes | In reply to @danielrf:matrix.org but let's see! Boots with the vendor/lineage patches | 20:23:29 |
kranzes | so is it just APEX now? | 20:23:34 |
danielrf | that's your only remaining difference, right? | 20:23:47 |
kranzes | i think so | 20:23:52 |
kranzes | https://github.com/Kranzes/robotnix-forklineageos/blob/master/flavors/lineageos/default.nix | 20:24:19 |
kranzes | take a look at this | 20:24:21 |
danielrf | envVars.RELEASE_TYPE is also commented out | 20:24:50 |
kranzes | In reply to @danielrf:matrix.org envVars.RELEASE_TYPE is also commented out i highly doubt that does anything | 20:25:24 |
kranzes |  Download image.png | 20:25:28 |
kranzes | but this is what's left | 20:25:33 |
kranzes | In reply to @kranzes:matrix.org i highly doubt that does anything in this case* | 20:25:43 |
kranzes | forklineageos uses a different android_vendor_lineage: https://github.com/ForkLineageOS/android_vendor_lineage | 20:27:20 |
kranzes | What do you think we should do next? | 20:29:11 |
danielrf | Two things we could do next: 1) dig through forklineageos changes that could be affected by either RELEASE_TYPE or OVERRIDE_TARGET_FLATTEN_APEX, or 2) continue bisecting by uncommenting RELEASE_TYPE and rebuilding/retesting | 20:31:14 |
danielrf | Actually one other way we could try: compare the extracted images between working and non-working robotnix builds | 20:34:12 |