| 8 Sep 2021 |
kranzes | oof | 00:20:12 |
danielrf | * At this point, I'd checkout https://github.com/ForkLineageOS/android_frameworks_base, try to revert that commit, and get a cleanly applying reverting patch | 00:20:25 |
kranzes | Is there no other way, instead of having to keep now a fork of it? | 00:21:15 |
kranzes | fetchpatch doesnt have something like a dirty patch | 00:21:23 |
kranzes | or a forced patch | 00:21:27 |
danielrf | I don't believe so. You don't need to keep a persistent fork, you just need to create a patch that works against their repo. | 00:22:09 |
danielrf | I'd try using git revert and git format-patch | 00:22:28 |
kranzes | In reply to @danielrf:matrix.org I don't believe so. You don't need to keep a persistent fork, you just need to create a patch that works against their repo. I don't get it then | 00:22:44 |
kranzes | In reply to @danielrf:matrix.org At this point, I'd checkout https://github.com/ForkLineageOS/android_frameworks_base, try to revert that commit, and get a cleanly applying reverting patch How do i get a "cleanly applying reverting patch"? | 00:24:15 |
danielrf | Sorry, I won't be able to help since I have some other work atm, but lots of the patches in robotnix were created by making local forks, applying changes and running git format-patch | 00:24:26 |
kranzes | Alright no worries | 00:24:58 |
danielrf | then, when there are updates to the upstream sources, so long as the patches still apply, I shouldn't need to update my local fork of them | 00:25:10 |
kranzes | I didn't get what you mean by "applying changes" | 00:25:43 |
danielrf | "applying changes" => "making new commits" | 00:26:04 |
danielrf | in this case, you want a commit that reverts the upstream MicroG changes | 00:26:17 |
danielrf | then you convert that commit(s) to a patch which you use in robotnix | 00:26:28 |
kranzes | Alright got it | 00:26:43 |
kranzes | thanks | 00:26:44 |
danielrf | np, good luck! | 00:26:51 |
kranzes | Git revert used to work on this, but they changed something from what i can tell | 00:35:48 |
kranzes | https://github.com/Kranzes/robotnix-personal/blob/main/flake.nix https://github.com/Kranzes/robotnix-personal/blob/main/patches/revert-forklineageos-microg.patch danielrf this works, its now building the rom! | 00:54:28 |
kranzes |  Download image.png | 00:55:59 |
kranzes | its time to go to bed now | 00:56:02 |
kranzes | and let it compile overnight | 00:56:08 |
danielrf | Just tagged and pushed vanilla-2021090722. Tested working on sunfish. | 06:59:29 |
danielrf | I've also has added support for barbet / Pixel 5a (5G). | 07:02:35 |
danielrf | This is untested in robotnix, but should likely work based on testing by users in other projects. If we have anyone here who has access to a Pixel 5a and would like to build/test, I'd love to hear any results. | 07:02:40 |
cde | danielrf: if you have a build I don't mind testing. | 07:11:31 |
danielrf | Thanks. I'll start a build now and give you a link tomorrow. About to go to sleep | 07:12:49 |
| * cde just woke up heh | 07:13:02 |