| 17 Oct 2025 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I especially don't know what "correct semantics" are, or what "correctness" is | 04:15:26 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I'm skeptical of correctness though | 04:15:31 |
ElvishJerricco | I made that very clear | 04:15:36 |
ElvishJerricco | in this case, the only thing that matters is that the libc is glibc | 04:15:44 |
ElvishJerricco | not gnu, not musl, not anything else | 04:15:55 |
ElvishJerricco | at this point I've explained myself five times | 04:16:10 |
ElvishJerricco | so I'm done | 04:16:13 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | For me, in my mind, isMusl and libc == musl evaluates to true | 04:16:59 |
ElvishJerricco | == musl is not the right semantics | 04:17:09 |
ElvishJerricco | as I already explained | 04:17:12 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I was unsure and still kind of am unsure, in what circumstances this can be untrue | 04:17:12 |
ElvishJerricco | literally | 04:17:17 |
ElvishJerricco | literally the only correct situation for that condition is if the libc is glibc | 04:17:30 |
ElvishJerricco | not "not musl" | 04:17:33 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I mean chill, if you don't want to explain this to me you don't have to | 04:17:35 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | But I'm in lib/systems/inspect.nix right now, and trying to figure it out | 04:17:45 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | isMusl =
with abis;
map (a: { abi = a; }) [
musl
musleabi
musleabihf
muslabin32
muslabi64
];
| 04:17:51 |
ElvishJerricco | Is this clear? There are other libcs than glibc or musl | 04:19:44 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Like, however complex this is, it can't evaluate to anything other than the libc being equal to musl though can it? | 04:19:58 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | nix-repl> lib.systems.parse.abis
{
android = { ... };
androideabi = { ... };
eabi = { ... };
eabihf = { ... };
elf = { ... };
gnu = { ... };
gnuabi64 = { ... };
gnuabielfv1 = { ... };
gnuabielfv2 = { ... };
gnuabin32 = { ... };
gnueabi = { ... };
gnueabihf = { ... };
msvc = { ... };
musl = { ... };
muslabi64 = { ... };
muslabin32 = { ... };
musleabi = { ... };
musleabihf = { ... };
uclibc = { ... };
uclibceabi = { ... };
uclibceabihf = { ... };
unknown = { ... };
}
| 04:20:07 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | like, yes, there are crazy combos, but musl always means the libc is musl right? | 04:20:21 |
ElvishJerricco | yes, but like I've said already, the condition is not about musl | 04:20:53 |
ElvishJerricco | musl / glibc is not a binary | 04:20:58 |
ElvishJerricco | it's not one or the other | 04:21:00 |
ElvishJerricco | the thing we care about here is if the libc is literally glibc. Is it clear that "not musl" is not equal to "is glibc"? | 04:21:22 |
ElvishJerricco | because "is glibc" is the correct semantics | 04:21:27 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | I wonder now how hostPlatform.libc even gets defined | 04:21:49 |
ElvishJerricco | https://github.com/NixOS/nixpkgs/blob/ff84020dd9cc87bab5c2675d62e555afeb09304f/lib/systems/default.nix#L120 | 04:22:09 |
matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | like what comes first, isMusl = or libc = | 04:22:11 |
ElvishJerricco | now, admittedly, that code is a little flawed, in that it assumes that if any of those other conditions isn't true then it should fallback to glibc, but that's its own bug and not relevant to using the correct semantics in this PR | 04:22:52 |