| 18 Oct 2025 |
 matthewcroughan @fosdem | * Seems good to me, I don't know how to test the mercurial stuff with google-re2 though | 16:05:38 |
| matthewcroughan @fosdem | I mean it might build, but who knows whether it works at runtime with mercurial the same exact way that is expected | 16:06:30 |
 dramforever | i checked the code in mercurial and it does runtime checks for feature testing | 16:07:28 |
| dramforever | like for example if it's missing test_match it uses match instead | 16:07:42 |
| dramforever | oh they even have code that add fb-re2 compat https://phab.mercurial-scm.org/D10284 | 16:11:18 |
| dramforever | so mercurial most definitely does not specifically depend on fb-re2 | 16:12:48 |
| dramforever | and given that the actual regex works the same under the hood, i really doubt there will be any problems | 16:13:12 |
| dramforever | oh they also catch re2 errors and fall back to normal re | 16:13:44 |
