| 18 Oct 2025 |
dramforever | the build.rs just uses unwrap(), so this isn't even in build.rs | 16:01:35 |
dramforever | unrelatedly, i don't know if this is excessive but it seems justified to: https://github.com/NixOS/nixpkgs/pull/453259 | 16:04:19 |
matthewcroughan @fosdem | Seems good to me, I don't know how to test the mercurial stuff with google-re2 | 16:05:35 |
matthewcroughan @fosdem | * Seems good to me, I don't know how to test the mercurial stuff with google-re2 though | 16:05:38 |
matthewcroughan @fosdem | I mean it might build, but who knows whether it works at runtime with mercurial the same exact way that is expected | 16:06:30 |
dramforever | i checked the code in mercurial and it does runtime checks for feature testing | 16:07:28 |
dramforever | like for example if it's missing test_match it uses match instead | 16:07:42 |
dramforever | oh they even have code that add fb-re2 compat https://phab.mercurial-scm.org/D10284 | 16:11:18 |