| 17 Aug 2021 |
das_j | I haven't seen anyone who is not admin submitting news | 13:56:03 |
@grahamc:nixos.org | ah gotcha | 13:56:17 |
@grahamc:nixos.org | yeah probably | 13:56:45 |
das_j | I do hope so :D | 13:56:56 |
das_j | Btw, is the eval-triggering API endpoint protected now? | 13:57:10 |
@grahamc:nixos.org | no | 18:51:23 |
| 18 Aug 2021 |
| p10r left the room. | 00:38:03 |
@grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1001 | 19:46:17 |
@grahamc:nixos.org | RFR as always ... :P | 19:51:53 |
| 19 Aug 2021 |
| hexagonk joined the room. | 02:38:55 |
@grahamc:nixos.org | ugh I peppered "use warnings" around and it is a lot | 20:59:00 |
@grahamc:nixos.org | Anyone know automake? I made this change:
https://github.com/NixOS/hydra/pull/1002/files#diff-0462e381b2fb3286568215681c8983490a37ac9ae0f0c5ee304df7fa6426d4af
and after it runs perlcritic . it errors with:
/nix/store/kxj6cblcsd1qcbbxlmbswwrn89zcmgd6-bash-4.4-p23/bin/bash: line 9: ./perlcritic: No such file or directory
FAIL: perlcritic
==================
1 of 1 test failed
==================
note I don't know automake, so this was totally a shot in the dark.
| 21:07:18 |
tomberek | grahamc (he/him): the syntax/style-checker isn't in scope? perlPackages.PerlCritic | 21:13:53 |
@grahamc:nixos.org | it is in scope, that error message is immediately after successfully running perlcritic, but it isn't available at ./perlcritic of course | 21:15:16 |
andi- | Perhaps since it is in the TESTS list? I haven't looked into the details but I could imagine the test scripts being "built" and then execute them | 21:16:42 |
andi- | keep in mind that make targets usually are there for producing said target | 21:17:01 |
@grahamc:nixos.org | right | 21:17:22 |
@grahamc:nixos.org | yeah, I don't really know how automake expects to be used to make this thing get called | 21:17:36 |
@grahamc:nixos.org | does automake automatically call all the targets? | 21:17:44 |
tomberek | i believe TESTS will be turned into targets that are called. https://www.gnu.org/software/automake/manual/html_node/Tests.html | 21:19:18 |
tomberek | oh, i see what you mean | 21:21:45 |
tomberek | PL_LOG_COMPILER | 21:24:48 |
tomberek | you need to set the test runner to be make | 21:25:50 |
@grahamc:nixos.org | eh? | 21:26:04 |
@grahamc:nixos.org | what test runner? | 21:26:14 |
tomberek | For all tests without a registered extension, the variables LOG_COMPILER, AM_LOG_FLAGS, and LOG_FLAGS may be used.
| 21:27:06 |
tomberek | i think default behavior is for TESTS to be a list of local files, not a list of make targets | 21:28:45 |
@grahamc:nixos.org | hrm | 21:29:58 |
@grahamc:nixos.org | I have to assume there is a better solution here, I only added it to TESTS because it was right there | 21:31:11 |
tomberek | i'll look after dinner | 21:34:19 |