| 18 Sep 2024 |
cleverca22 | the entire binary cache api is broken | 21:08:25 |
cleverca22 | narinfo files work, but nar's dont, so nothing can DL | 21:10:08 |
John Ericson | cleverca22: ah that looks like one we missed | 21:25:34 |
John Ericson | Make it $MACHINE_LOCAL_STORE->isValidPath(...) | 21:26:15 |
John Ericson | cleverca22: it would be nice if you could PR it to the nix-2.21 branch | 21:27:30 |
| 19 Sep 2024 |
| @max.hausch:helsinki-systems.de left the room. | 08:48:28 |
| 20 Sep 2024 |
cleverca22 | <div class="page-header">500 Internal Server Error </div> <div class="alert alert-error">Caught exception in Hydra::View::NARInfo->process "Can't locate object method "readFile" via package "/etc/nix/keys/secret-key-file" (perhaps you forgot to load "/etc/nix/keys/secret-key-file"?) at /nix/store/78qww3jbcnvbhw6xpfn7mc0bpph8ngx4-hydra-0.1.20240920.cc1b6d3/libexec/hydra/lib/Hydra/View/NARInfo.pm line 39."</div>
John Ericson applied that patch and upgraded hydra to 1 commit ahead of that branch, now the narinfo endpoint is broken instead
| 08:00:40 |
cleverca22 | --- a/src/lib/Hydra/View/NARInfo.pm
+++ b/src/lib/Hydra/View/NARInfo.pm
@@ -36,7 +36,7 @@ sub process {
# Optionally, sign the NAR info file we just created.
my $secretKeyFile = $c->config->{binary_cache_secret_key_file};
if (defined $secretKeyFile) {
- my $secretKey = readFile $secretKeyFile;
+ my $secretKey = readFile($secretKeyFile);
my $fingerprint = fingerprintPath($storePath, $narHash, $narSize, $refs);
my $sig = signString($secretKey, $fingerprint);
$info .= "Sig: $sig\n";
| 08:51:37 |
cleverca22 | i noticed, the function call here, is missing some parens | 08:51:44 |
@janne.hess:helsinki-systems.de | In reply to @cleverca22:matrix.org i noticed, the function call here, is missing some parens That's valid in Perl 🤡 | 09:01:20 |