| 18 Oct 2021 |
 das_j | Could be worked around by the queue runner and evaluator posting their current timestamp into postgres and displaying a warning in the web ui if the difference to the current timestamp is too large | 13:19:44 |
| das_j | That would also show if something bad happened | 13:20:05 |
 @grahamc:nixos.org | I'd like to add a prometheus exporter to the evaluator and queue runner. I've sent a proposal for the queue runner work to a client but they weren't ready to spend the time & money on it | 13:20:11 |
| das_j | Can't you just use the json exporter and pluck /queue-runner-status into that? | 13:21:18 |
| @grahamc:nixos.org | the instrumentation work I proposed was focused on identifying why it gets "stuck" | 13:21:54 |
| @grahamc:nixos.org | but another thing is having the exporter in the runner itself means you get liveness checks for "free" | 13:22:13 |
| das_j | Wouldn't something like opentracing be more suitable for that task? I haven't used it myself but it seems quite fitting and could also be used for more detailed inspection | 13:23:29 |
| @grahamc:nixos.org | I'm open | 13:23:46 |
| das_j | My C++ skills are more limited than my Perl skills :/ | 13:24:06 |
| @grahamc:nixos.org | mine aren't winning any awards but I don't mind diving in | 13:26:38 |
| das_j | I already learned Perl the hard way in the last days, no need to drive myself too insane :D | 13:27:29 |
| das_j | (Disclaimer: I'm not a Perl developer and I have zero training!) | 13:28:00 |
| @grahamc:nixos.org | hehe | 13:29:14 |
| @grahamc:nixos.org | what're you learning perl for?? :) | 13:29:21 |
| das_j | not learning, just doing | 13:30:14 |
| das_j | it's for switch-to-configuration.pl (the link works btw) | 13:30:27 |
| @grahamc:nixos.org | ah | 13:30:34 |
| @grahamc:nixos.org | oh my gosh | 13:30:43 |
| das_j | it's actually less awful than I expected. I'm used to doing hacks all the time and Perl just lets me do them | 13:31:09 |
| das_j | Not like Python which is always like "oh no you can't do that that's not the way we intended" | 13:31:28 |
| @grahamc:nixos.org | I find it so bizarre that our most important, least safe things we do are written in longish bash & perl scripts without any code quality standards or tests | 13:35:43 |
| das_j | There are some tests now (at least for stc) | 13:41:03 |
| @grahamc:nixos.org | nice | 13:41:22 |
| 20 Oct 2021 |
| @grahamc:nixos.org | a small PRs reducing warning noise: https://github.com/NixOS/hydra/pull/1043
a small PR making GitHubPulls not use jq https://github.com/NixOS/hydra/pull/1042 | 02:14:02 |
| das_j | grahamc (he/him): wouldn't it be nicer to do something like return ($self->{config}->{enable_bitbucket_status} // 0) == 1;? | 06:48:41 |
| @grahamc:nixos.org | sounds nice | 13:43:17 |
| @grahamc:nixos.org | das_j: | 14:40:31 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1043/commits/a36d23c1dd6070ab8603b20e939e077b838b6ba7 | 14:40:32 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1043/commits/a887b3d3466df58b92ac3ea5cd6cc4a69ce7d095 | 14:40:38 |
| @grahamc:nixos.org | here's a PR bringing the codebase up to perlcritic level 3: https://github.com/NixOS/hydra/pull/1044 | 15:49:26 |
