| 20 Oct 2021 |
 @grahamc:nixos.org | does anyone intend on reviewing #1044 (perlcritic level 3)? I'd love some eyes on it, but if not I'm inclined to just press the button | 16:32:43 |
 das_j | I can take a look but I can't guarantee I'll spot all issues ;) | 16:35:17 |
| @grahamc:nixos.org | of course not | 16:36:42 |
 Rick (Mindavi) | I looked earlier, but it looks different now :p, don't see any obvious issues but I've never written perl | 16:37:02 |
| Rick (Mindavi) | Was wondering about the dependency that was added though | 16:37:14 |
| @grahamc:nixos.org | 👍️just replied on the thread | 16:38:26 |
| das_j | Is there a perlcritic level that complains about calls without parathesis btw? :P | 16:46:44 |
| das_j | that seems really incosistent throughout the codebase and somebody complained about me not fixing it in switch-to-configuration ;) | 16:47:08 |
| @grahamc:nixos.org | who knows ... | 16:47:29 |
| @grahamc:nixos.org | TIL function signatures are "experimental" but practically not experimental and we should use them | 16:47:40 |
| @grahamc:nixos.org | and they work on methods too, while prototypes did not | 16:47:47 |
| das_j |
my @expected_names = ( "bogus-1", "bogus-2" );
| 16:48:27 |
| das_j | shouldn't you use qw here? | 16:48:33 |
| @grahamc:nixos.org | I guess | 16:48:43 |
| das_j | apart from the open() vs open thing, it looks good to me | 16:49:07 |
| @grahamc:nixos.org | I thought about migrating all the opens to use parens and got lazy ... :) | 16:52:58 |
| das_j | understandable | 17:10:37 |
| @grahamc:nixos.org | I made them all open's use parens | 17:16:22 |
| @grahamc:nixos.org | I'm going to smash the merge button since nothing material has changed since the reviews, except the parens | 17:16:36 |
| @grahamc:nixos.org | thank you for the reviews :) | 17:16:45 |
| @grahamc:nixos.org | data "hydra_job" "system" {
project = "app"
jobset = "production"
job = "webserver"
}
resource "aws_instance" "web" {
# ...
provisioner "remote-exec" {
inline = [
"nix-env --profile /nix/var/nix/profiles/system --set '${data.hydra_job.system.outputs.out.path}'",
"/nix/var/nix/profiles/system/bin/switch-to-configuration switch",
]
}
}
| 19:07:38 |
| @grahamc:nixos.org | * data "hydra_job" "system" {
project = "app"
jobset = "production"
job = "webserver"
}
resource "aws_instance" "web" {
# ...
provisioner "remote-exec" {
inline = [
"nix-env --profile /nix/var/nix/profiles/system --set '${data.hydra_job.system.outputs.out.path}'",
"/nix/var/nix/profiles/system/bin/switch-to-configuration switch",
]
}
}
| 19:07:41 |
| @grahamc:nixos.org | * data "hydra_job" "system" {
project = "app"
jobset = "production"
job = "webserver"
}
resource "aws_instance" "web" {
# ...
provisioner "remote-exec" {
inline = [
"nix-env --profile /nix/var/nix/profiles/system --set '${data.hydra_job.system.outputs.out.path}'",
"/nix/var/nix/profiles/system/bin/switch-to-configuration switch",
]
}
}
| 19:07:51 |
| @grahamc:nixos.org | just something I'm noodling on | 19:09:53 |
| das_j | is this some hail alternative? | 19:10:03 |
| @grahamc:nixos.org | no | 19:10:10 |
| @grahamc:nixos.org | but you could use this to boot a NixOS AMI and get its very first config deployed which is set up to pull from hydra on a regular baslis | 19:10:34 |
| @grahamc:nixos.org | * but you could use this to boot a NixOS AMI and get its very first config deployed which is set up to pull from hydra on a regular basis | 19:10:36 |
| das_j | ah that's just an initial provisioning thing | 19:10:56 |
| @grahamc:nixos.org | yeah | 19:11:00 |
